❄️ Flaky tests (#39877)

* Attempt at deflaking amp-consent tests * Disable flaky test * Disable flaky test
ampproject · Mar 6, 2024 · 773b80a · 773b80a
1 parent fa38954
commit 773b80a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/extensions/amp-analytics/0.1/test/test-events.js b/extensions/amp-analytics/0.1/test/test-events.js
@@ -1394,7 +1394,8 @@ describes.realWin('Events', {amp: 1}, (env) => {
       });
     });
 
-    it(
+    // TODO(#39879): fix this flaky test.
+    it.skip(
       'timers started and stopped by the same event on the same target' +
         ' do not have race condition problems',
       () => {

diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-carousel.js b/extensions/amp-base-carousel/0.1/test-e2e/test-carousel.js
@@ -59,7 +59,8 @@ describes.endtoend(
       await expect(slidesRects[0].width).to.equal(pageWidth);
     });
 
-    it('should layout the two adjacent slides', async function () {
+    // TODO(#24195): fix this flaky test.
+    it.skip('should layout the two adjacent slides', async function () {
       const [firstSlideRect, secondSlideRect, lastSlideRect] = [
         await controller.getElementRect(await getSlide(controller, 0)),
         await controller.getElementRect(await getSlide(controller, 1)),

diff --git a/extensions/amp-consent/0.1/test/test-amp-consent.js b/extensions/amp-consent/0.1/test/test-amp-consent.js
@@ -4,7 +4,7 @@ import {xhrServiceForTesting} from '#service/xhr-impl';
 
 import {dev, user} from '#utils/log';
 
-import {macroTask} from '#testing/helpers';
+import {macroTask, sleep} from '#testing/helpers';
 
 import {
   registerServiceBuilder,
@@ -1161,7 +1161,7 @@ describes.realWin(
 
         beforeEach(async () => {
           ampConsent.buildCallback();
-          await macroTask();
+          await sleep(50);
           managerSpy = env.sandbox.spy(
             ampConsent.consentStateManager_,
             'updateConsentInstancePurposes'