Hide overflow on successful resize (#30114)

ampproject · Sep 17, 2020 · 7fc4261 · 7fc4261
1 parent 77f880f
commit 7fc4261
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/extensions/amp-iframe/0.1/amp-iframe.js b/extensions/amp-iframe/0.1/amp-iframe.js
@@ -801,6 +801,11 @@ export class AmpIframe extends AMP.BaseElement {
           if (newWidth !== undefined) {
             this.element.setAttribute('width', newWidth);
           }
+          this.element.overflowCallback(
+            /* overflown */ false,
+            newHeight,
+            newWidth
+          );
         },
         () => {}
       );

diff --git a/extensions/amp-iframe/0.1/test/test-amp-iframe.js b/extensions/amp-iframe/0.1/test/test-amp-iframe.js
@@ -693,6 +693,23 @@ describes.realWin(
         expect(attemptChangeSize).to.be.calledWith(217, 114);
       });
 
+      it('should hide overflow element after resize', async function () {
+        const ampIframe = createAmpIframe(env, {
+          src: iframeSrc,
+          sandbox: 'allow-scripts',
+          width: 100,
+          height: 100,
+          resizable: '',
+        });
+        await waitForAmpIframeLayoutPromise(doc, ampIframe);
+        const impl = await ampIframe.getImpl();
+        const overflowElement = impl.getOverflowElement();
+        overflowElement.classList.toggle('amp-visible', true);
+        impl.updateSize_(217, '114' /* be tolerant to string number */);
+        await timer.promise(IFRAME_MESSAGE_TIMEOUT);
+        expect(overflowElement.classList.contains('amp-visible')).to.be.false;
+      });
+
       it('should resize amp-iframe when only height is provided', function* () {
         const ampIframe = createAmpIframe(env, {
           src: iframeSrc,