Skip to content

Commit

Permalink
address review
Browse files Browse the repository at this point in the history
  • Loading branch information
alanorozco committed Sep 8, 2021
1 parent 77db078 commit 80fdc07
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 15 deletions.
6 changes: 3 additions & 3 deletions extensions/amp-animation/0.1/storybook/Basic.amp.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const KEYFRAMES_OPTIONS = {
},
};

const keyframesOptionValues = Object.keys(KEYFRAMES_OPTIONS);
const keyframesOptions = Object.keys(KEYFRAMES_OPTIONS);

const BLOCK_STYLE = {
background: 'blue',
Expand All @@ -45,11 +45,11 @@ export default {
argTypes: {
keyframesName: {
control: {type: 'select'},
options: keyframesOptionValues,
options: keyframesOptions,
},
},
args: {
keyframesName: keyframesOptionValues[0],
keyframesName: keyframesOptions[0],
easing: 'cubic-bezier(0,0,.21,1)',
},
};
Expand Down
15 changes: 3 additions & 12 deletions extensions/amp-brightcove/1.0/storybook/Basic.amp.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,28 +14,19 @@ export default {
'data-video-id': 'ref:amp-docs-sample',
'data-player-id': 'SyIOV8yWM',
'data-account': '1290862519001',
'data-referrer': 'EXTERNAL_REFERRER',
height: '270',
width: '480',
},
};

export const Default = (args) => {
return (
<amp-brightcove
data-referrer="EXTERNAL_REFERRER"
layout="responsive"
{...args}
></amp-brightcove>
);
return <amp-brightcove layout="responsive" {...args}></amp-brightcove>;
};

export const WithPlaceholderAndFallback = (args) => {
return (
<amp-brightcove
data-referrer="EXTERNAL_REFERRER"
layout="responsive"
{...args}
>
<amp-brightcove layout="responsive" {...args}>
<div placeholder style="background:red">
Placeholder. Loading content...
</div>
Expand Down

0 comments on commit 80fdc07

Please sign in to comment.