Wrap pushState/replaceState calls in try/catch blocks (#38388)

ampproject · Aug 11, 2022 · 83d345e · 83d345e
1 parent b2cc07c
commit 83d345e
Showing 1 changed file with 19 additions and 11 deletions.
diff --git a/src/service/history-impl.js b/src/service/history-impl.js
@@ -413,22 +413,30 @@ export class HistoryBindingNatural_ {
         history.originalReplaceState || history.replaceState.bind(history);
       pushState = (state, opt_title, opt_url) => {
         this.unsupportedState_ = state;
-        this.origPushState_(
-          state,
-          opt_title,
-          // A bug in edge causes paths to become undefined if URL is
-          // undefined, filed here: https://goo.gl/KlImZu
-          opt_url || null
-        );
+        try {
+          this.origPushState_(
+            state,
+            opt_title,
+            // A bug in edge causes paths to become undefined if URL is
+            // undefined, filed here: https://goo.gl/KlImZu
+            opt_url || null
+          );
+        } catch (e) {
+          dev().error(TAG_, 'pushState failed: ' + e.message);
+        }
       };
       replaceState = (state, opt_title, opt_url) => {
         this.unsupportedState_ = state;
         // NOTE: check for `undefined` since IE11 and Edge
         // unexpectedly coerces it into a `string`.
-        if (opt_url !== undefined) {
-          this.origReplaceState_(state, opt_title, opt_url);
-        } else {
-          this.origReplaceState_(state, opt_title);
+        try {
+          if (opt_url !== undefined) {
+            this.origReplaceState_(state, opt_title, opt_url);
+          } else {
+            this.origReplaceState_(state, opt_title);
+          }
+        } catch (e) {
+          dev().error(TAG_, 'replaceState failed: ' + e.message);
         }
       };
       if (!history.originalPushState) {