core mode: add internalRuntimeVersion

3p/integration-lib.js

@@ -26,7 +26,7 @@ import {
   userAssert,
 } from '../src/log';
 import {installEmbedStateListener, manageWin} from './environment';
-import {internalRuntimeVersion} from '../src/internal-version';
+import {internalRuntimeVersion} from '#core/mode';
 import {parseJson} from '#core/types/object/json';
 import {run, setExperimentToggles} from './3p';
 import {urls} from '../src/config';

ads/google/a4a/utils.js

@@ -28,7 +28,7 @@ import {getMode} from '../../../src/mode';
 import {getOrCreateAdCid} from '../../../src/ad-cid';
 import {getPageLayoutBoxBlocking} from '#core/dom/layout/page-layout-box';
 import {getTimingDataSync} from '#service/variable-source';
-import {internalRuntimeVersion} from '../../../src/internal-version';
+import {internalRuntimeVersion} from '#core/mode';
 import {parseJson} from '#core/types/object/json';
 import {whenUpgradedToCustomElement} from '../../../src/amp-element-helpers';
 

build-system/test-configs/dep-check-config.js

@@ -104,7 +104,6 @@ exports.rules = [
       '3p/**->src/mode.js',
       '3p/**->src/core/types/object/json.js',
       '3p/**->src/3p-frame-messaging.js',
-      '3p/**->src/internal-version.js',
       '3p/polyfills.js->src/polyfills/math-sign.js',
       '3p/polyfills.js->src/polyfills/object-assign.js',
       '3p/polyfills.js->src/polyfills/object-values.js',
@@ -139,7 +138,6 @@ exports.rules = [
       'ads/**->src/url.js',
       'ads/**->src/core/dom/static-template.js',
       'ads/**->src/core/dom/style.js',
-      'ads/**->src/internal-version.js',
       // ads/google/a4a doesn't contain 3P ad code and should probably move
       // somewhere else at some point
       'ads/google/a4a/**->src/ad-cid.js',

build-system/test-configs/forbidden-terms.js

@@ -150,7 +150,7 @@ const forbiddenTermsGlobal = {
     message:
       'Do not use build constants directly. Instead, use the helpers in `#core/mode`.',
     allowlist: [
-      'src/internal-version.js',
+      'src/core/mode/internal-runtime-version.js',
       'src/core/mode/minified.js',
       'src/core/mode/for-testing.js',
       'build-system/compile/build-constants.js',

extensions/amp-ad-network-valueimpression-impl/0.1/amp-ad-network-valueimpression-impl.js

@@ -26,7 +26,7 @@ import {getBinaryType, isExperimentOn} from '#experiments';
 import {getFlexibleAdSlotData} from './flexible-ad-slot-utils';
 import {getOrCreateAdCid} from '../../../src/ad-cid';
 import {getPageLayoutBoxBlocking} from '#core/dom/layout/page-layout-box';
-import {internalRuntimeVersion} from '../../../src/internal-version';
+import {internalRuntimeVersion} from '#core/mode';
 import {stringHash32} from '#core/types/string';
 
 /** @type {string} */

extensions/amp-addthis/0.1/amp-addthis.js

@@ -66,7 +66,7 @@ import {
 } from './addthis-utils/mode';
 import {getOgImage} from './addthis-utils/meta';
 import {getWidgetOverload} from './addthis-utils/get-widget-id-overloaded-with-json-for-anonymous-mode';
-import {internalRuntimeVersion} from '../../../src/internal-version';
+import {internalRuntimeVersion} from '#core/mode';
 import {listen} from '../../../src/event-helper';
 import {parseUrlDeprecated} from '../../../src/url';
 import {setStyle} from '#core/dom/style';

extensions/amp-analytics/0.1/iframe-transport.js

@@ -19,7 +19,7 @@ import {createElementWithAttributes} from '#core/dom';
 import {devAssert, user} from '../../../src/log';
 import {getMode} from '../../../src/mode';
 import {hasOwn} from '#core/types/object';
-import {internalRuntimeVersion} from '../../../src/internal-version';
+import {internalRuntimeVersion} from '#core/mode';
 import {toggle} from '#core/dom/style';
 import {urls} from '../../../src/config';
 

extensions/amp-recaptcha-input/0.1/amp-recaptcha-service.js

@@ -28,7 +28,7 @@ import {dict} from '#core/types/object';
 import {getMode} from '../../../src/mode';
 import {getServicePromiseForDoc} from '../../../src/service-helpers';
 import {getSourceOrigin} from '../../../src/url';
-import {internalRuntimeVersion} from '../../../src/internal-version';
+import {internalRuntimeVersion} from '#core/mode';
 import {listenFor, postMessage} from '../../../src/iframe-helper';
 import {loadPromise} from '../../../src/event-helper';
 import {removeElement} from '#core/dom';

src/core/mode/index.js

@@ -18,3 +18,4 @@ export {isFortesting} from './for-testing';
 export {isLocalDev} from './local-dev';
 export {isMinified} from './minified';
 export {isTest} from './test';
+export {internalRuntimeVersion} from './internal-runtime-version';

src/internal-version.js → src/core/mode/internal-runtime-version.js

@@ -1,5 +1,5 @@
 /**
- * Copyright 2019 The AMP HTML Authors. All Rights Reserved.
+ * Copyright 2021 The AMP HTML Authors. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -25,4 +25,4 @@
  */
 export function internalRuntimeVersion() {
   return INTERNAL_RUNTIME_VERSION;
-}
+}

src/mode.js

@@ -24,7 +24,6 @@ import {internalRuntimeVersion} from './internal-version';
  *   development: boolean,
  *   minified: boolean,
  *   test: boolean,
- *   log: (string|undefined),
  *   version: string,
  *   rtvVersion: string,
  *   runtime: (null|string|undefined),