✅ Remove unnessary async annotations from E2E tests (#35672)

ampproject · Aug 13, 2021 · 87e21c1 · 87e21c1
1 parent 862f51f
commit 87e21c1
Show file tree

Hide file tree

Showing 72 changed files with 117 additions and 120 deletions.
diff --git a/extensions/amp-accordion/1.0/test-e2e/test-amp-accordion.js b/extensions/amp-accordion/1.0/test-e2e/test-amp-accordion.js
@@ -22,7 +22,7 @@ describes.endtoend(
     experiments: ['bento-accordion'],
     environments: ['single', 'viewer-demo'],
   },
-  async (env) => {
+  (env) => {
     let controller;
 
     let header1;

diff --git a/extensions/amp-accordion/1.0/test-e2e/test-single-expand.js b/extensions/amp-accordion/1.0/test-e2e/test-single-expand.js
@@ -22,10 +22,10 @@ describes.endtoend(
     experiments: ['bento-accordion'],
     environments: ['single', 'viewer-demo'],
   },
-  async (env) => {
+  (env) => {
     let controller;
 
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 

diff --git a/extensions/amp-analytics/0.1/test-e2e/test-browser-event.js b/extensions/amp-analytics/0.1/test-e2e/test-browser-event.js
@@ -24,7 +24,7 @@ describes.endtoend(
   (env) => {
     let controller;
 
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 

diff --git a/extensions/amp-analytics/0.1/test-e2e/test-iframe-transport.js b/extensions/amp-analytics/0.1/test-e2e/test-iframe-transport.js
@@ -23,7 +23,7 @@ describes.endtoend(
   (env) => {
     let controller;
 
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 

diff --git a/extensions/amp-animation/0.1/test-e2e/test-amp-animation.js b/extensions/amp-animation/0.1/test-e2e/test-amp-animation.js
@@ -24,7 +24,7 @@ describes.endtoend(
   (env) => {
     let controller;
 
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 

diff --git a/extensions/amp-auto-lightbox/0.1/test-e2e/test-amp-auto-lightbox.js b/extensions/amp-auto-lightbox/0.1/test-e2e/test-amp-auto-lightbox.js
@@ -22,10 +22,10 @@ describes.endtoend(
     environments: ['single'],
     browsers: ['chrome'],
   },
-  async (env) => {
+  (env) => {
     let controller;
 
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 

diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-advance.js b/extensions/amp-base-carousel/0.1/test-e2e/test-advance.js
@@ -28,7 +28,7 @@ describes.endtoend(
     environments: ['single'],
     initialRect: {width: pageWidth, height: pageHeight},
   },
-  async (env) => {
+  (env) => {
     let controller;
     let nextArrow;
     let prevArrow;

diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-in-lightbox.js b/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-in-lightbox.js
@@ -22,12 +22,12 @@ describes.endtoend(
     fixture: 'amp-base-carousel/arrows-in-lightbox.amp.html',
     environments: ['single'],
   },
-  async (env) => {
+  (env) => {
     let controller;
     let nextArrow;
     let prevArrow;
 
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 

diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js b/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js
@@ -31,7 +31,7 @@ describes.endtoend(
     //TODO(spaharmi): fails on shadow demo
     environments: ['single', 'viewer-demo'],
   },
-  async (env) => {
+  (env) => {
     let controller;
     let prevArrow;
     let nextArrow;

diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-autoadvance.js b/extensions/amp-base-carousel/0.1/test-e2e/test-autoadvance.js
@@ -27,14 +27,14 @@ describes.endtoend(
     experiments: ['amp-base-carousel', 'layers'],
     initialRect: {width: pageWidth, height: pageHeight},
   },
-  async (env) => {
+  (env) => {
     let controller;
 
     function rect(el) {
       return controller.getElementRect(el);
     }
 
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 

diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-carousel.js b/extensions/amp-base-carousel/0.1/test-e2e/test-carousel.js
@@ -36,7 +36,7 @@ describes.endtoend(
     //TODO(spaharmi): fails on shadow demo
     environments: ['single', 'viewer-demo'],
   },
-  async (env) => {
+  (env) => {
     /** The total number of slides in the carousel */
     const SLIDE_COUNT = 7;
     let controller;

diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-default-attributes.js b/extensions/amp-base-carousel/0.1/test-e2e/test-default-attributes.js
@@ -31,7 +31,7 @@ describes.endtoend(
     let scrollContainer;
     let loop;
 
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 

diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-goToSlide.js b/extensions/amp-base-carousel/0.1/test-e2e/test-goToSlide.js
@@ -22,12 +22,12 @@ describes.endtoend(
     fixture: 'amp-base-carousel/arrows-in-lightbox.amp.html',
     environments: ['single'],
   },
-  async (env) => {
+  (env) => {
     let controller;
     let slides;
     let prevArrow;
 
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 

diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-grouping.js b/extensions/amp-base-carousel/0.1/test-e2e/test-grouping.js
@@ -27,7 +27,7 @@ describes.endtoend(
     experiments: ['amp-base-carousel', 'layers'],
     initialRect: {width: pageWidth, height: pageHeight},
   },
-  async (env) => {
+  (env) => {
     const slideWidth = pageWidth / 2;
     let controller;
 

diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-hidden-controls.js b/extensions/amp-base-carousel/0.1/test-e2e/test-hidden-controls.js
@@ -47,7 +47,7 @@ describes.endtoend(
 
     let controller;
 
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 

diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-initial-slide.js b/extensions/amp-base-carousel/0.1/test-e2e/test-initial-slide.js
@@ -27,10 +27,10 @@ describes.endtoend(
     environments: ['single', 'viewer-demo'],
     initialRect: {width: pageWidth, height: pageHeight},
   },
-  async (env) => {
+  (env) => {
     let controller;
 
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 

diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-mixed-lengths-no-snap.js b/extensions/amp-base-carousel/0.1/test-e2e/test-mixed-lengths-no-snap.js
@@ -29,7 +29,7 @@ describes.endtoend(
     //TODO(spaharmi): fails on viewer and shadow demo
     environments: ['single'],
   },
-  async (env) => {
+  (env) => {
     let controller;
 
     function prop(el, name) {
@@ -41,7 +41,7 @@ describes.endtoend(
       await expect(prop(spacers[1], 'offsetWidth')).to.equal(width);
     }
 
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 

diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-mixed-lengths.js b/extensions/amp-base-carousel/0.1/test-e2e/test-mixed-lengths.js
@@ -27,7 +27,7 @@ describes.endtoend(
     experiments: ['amp-base-carousel', 'layers'],
     initialRect: {width: pageWidth, height: pageHeight},
   },
-  async (env) => {
+  (env) => {
     let controller;
 
     function prop(el, name) {
@@ -39,7 +39,7 @@ describes.endtoend(
       await expect(prop(spacers[1], 'offsetWidth')).to.equal(width);
     }
 
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 
@@ -69,20 +69,17 @@ describes.endtoend(
           await assertSpacerWidth(1, slideTwoWidth);
         });
 
-      //TODO(sparhami): fails on shadow demo
-      it.configure()
-        .skipShadowDemo()
-        // TODO(#35241): flaky test disabled in #35176
-        .skip('should snap on the center point', async () => {
-          const el = await getScrollingElement(controller);
-          const slides = await getSlides(controller);
-          const scrollAmount = 1 + slideOneWidth / 2;
+      // TODO(#35241): flaky test disabled in #35176
+      it.skip('should snap on the center point', async () => {
+        const el = await getScrollingElement(controller);
+        const slides = await getSlides(controller);
+        const scrollAmount = 1 + slideOneWidth / 2;
 
-          await controller.scrollBy(el, {left: scrollAmount});
-          await expect(controller.getElementRect(slides[1])).to.include({
-            x: (pageWidth - slideTwoWidth) / 2,
-          });
+        await controller.scrollBy(el, {left: scrollAmount});
+        await expect(controller.getElementRect(slides[1])).to.include({
+          x: (pageWidth - slideTwoWidth) / 2,
         });
+      });
     });
   }
 );
diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-non-looping.js b/extensions/amp-base-carousel/0.1/test-e2e/test-non-looping.js
@@ -27,7 +27,7 @@ describes.endtoend(
     experiments: ['amp-base-carousel', 'layers'],
     initialRect: {width: pageWidth, height: pageHeight},
   },
-  async (env) => {
+  (env) => {
     /** The total number of slides in the carousel */
     const SLIDE_COUNT = 4;
     let controller;
@@ -36,7 +36,7 @@ describes.endtoend(
       return controller.getElementProperty(el, name);
     }
 
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 

diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-responsive.js b/extensions/amp-base-carousel/0.1/test-e2e/test-responsive.js
@@ -29,14 +29,14 @@ describes.endtoend(
     //TODO(spaharmi): fails on shadow demo
     environments: ['single', 'viewer-demo'],
   },
-  async (env) => {
+  (env) => {
     let controller;
 
     function prop(el, name) {
       return controller.getElementProperty(el, name);
     }
 
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 

diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-rtl.js b/extensions/amp-base-carousel/0.1/test-e2e/test-rtl.js
@@ -30,11 +30,11 @@ describes.endtoend(
     // TODO(sparhami) Make other environments work too
     environments: ['single'],
   },
-  async (env) => {
+  (env) => {
     /** The total number of slides in the carousel */
     const SLIDE_COUNT = 7;
     let controller;
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 

diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-snap-property.js b/extensions/amp-base-carousel/0.1/test-e2e/test-snap-property.js
@@ -26,7 +26,7 @@ describes.endtoend(
   async function (env) {
     let controller;
 
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 

diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-vertical.js b/extensions/amp-base-carousel/0.1/test-e2e/test-vertical.js
@@ -27,7 +27,7 @@ describes.endtoend(
     experiments: ['amp-base-carousel', 'layers'],
     initialRect: {width: pageWidth, height: pageHeight},
   },
-  async (env) => {
+  (env) => {
     /** The total number of slides in the carousel */
     const SLIDE_COUNT = 7;
     let controller;
@@ -40,7 +40,7 @@ describes.endtoend(
       return controller.getElementRect(el);
     }
 
-    beforeEach(async () => {
+    beforeEach(() => {
       controller = env.controller;
     });
 

diff --git a/extensions/amp-base-carousel/1.0/test-e2e/test-advance.js b/extensions/amp-base-carousel/1.0/test-e2e/test-advance.js
@@ -35,7 +35,7 @@ describes.endtoend(
     environments: ['single'],
     initialRect: {width: pageWidth, height: pageHeight},
   },
-  async (env) => {
+  (env) => {
     let controller;
     let nextArrow;
     let prevArrow;

diff --git a/extensions/amp-base-carousel/1.0/test-e2e/test-arrows-non-looping.js b/extensions/amp-base-carousel/1.0/test-e2e/test-arrows-non-looping.js
@@ -36,7 +36,7 @@ describes.endtoend(
     initialRect: {width: pageWidth, height: pageHeight},
     environments: ['single', 'viewer-demo'],
   },
-  async (env) => {
+  (env) => {
     const styles = useStyles();
     let controller;
     let prevArrow;

diff --git a/extensions/amp-base-carousel/1.0/test-e2e/test-autoadvance.js b/extensions/amp-base-carousel/1.0/test-e2e/test-autoadvance.js
@@ -29,7 +29,7 @@ describes.endtoend(
     initialRect: {width: pageWidth, height: pageHeight},
     environments: ['single', 'viewer-demo'],
   },
-  async (env) => {
+  (env) => {
     let controller;
     const styles = useStyles();
 

diff --git a/extensions/amp-base-carousel/1.0/test-e2e/test-component.js b/extensions/amp-base-carousel/1.0/test-e2e/test-component.js
@@ -32,7 +32,7 @@ describes.endtoend(
     initialRect: {width: pageWidth, height: pageHeight},
     environments: ['single', 'viewer-demo'],
   },
-  async (env) => {
+  (env) => {
     /** The total number of slides in the carousel */
     const SLIDE_COUNT = 7;
     let controller;

diff --git a/extensions/amp-base-carousel/1.0/test-e2e/test-grouping.js b/extensions/amp-base-carousel/1.0/test-e2e/test-grouping.js
@@ -33,7 +33,7 @@ describes.endtoend(
     initialRect: {width: pageWidth, height: pageHeight},
     environments: ['single'],
   },
-  async (env) => {
+  (env) => {
     let controller, btnPrev, btnNext;
 
     const styles = useStyles();

diff --git a/extensions/amp-base-carousel/1.0/test-e2e/test-mixed-lengths-no-snap.js b/extensions/amp-base-carousel/1.0/test-e2e/test-mixed-lengths-no-snap.js
@@ -29,7 +29,7 @@ describes.endtoend(
     initialRect: {width: pageWidth, height: pageHeight},
     environments: ['single', 'viewer-demo'],
   },
-  async (env) => {
+  (env) => {
     let controller;
     const styles = useStyles();
 

diff --git a/extensions/amp-base-carousel/1.0/test-e2e/test-mixed-lengths.js b/extensions/amp-base-carousel/1.0/test-e2e/test-mixed-lengths.js
@@ -29,7 +29,7 @@ describes.endtoend(
     environments: ['single', 'viewer-demo'],
     initialRect: {width: pageWidth, height: pageHeight},
   },
-  async (env) => {
+  (env) => {
     let controller;
     const styles = useStyles();
 

diff --git a/extensions/amp-base-carousel/1.0/test-e2e/test-non-looping.js b/extensions/amp-base-carousel/1.0/test-e2e/test-non-looping.js
@@ -29,7 +29,7 @@ describes.endtoend(
     environments: ['single', 'viewer-demo'],
     initialRect: {width: pageWidth, height: pageHeight},
   },
-  async (env) => {
+  (env) => {
     /** The total number of slides in the carousel */
     const SLIDE_COUNT = 4;
     const styles = useStyles();

diff --git a/extensions/amp-base-carousel/1.0/test-e2e/test-responsive.js b/extensions/amp-base-carousel/1.0/test-e2e/test-responsive.js
@@ -29,7 +29,7 @@ describes.endtoend(
     initialRect: {width: pageWidth, height: pageHeight},
     environments: ['single', 'viewer-demo'],
   },
-  async (env) => {
+  (env) => {
     const styles = useStyles();
     let controller;
     let carousel;