Create tag_spec

ampproject · Jan 7, 2019 · 8a1db50 · 8a1db50
1 parent d403d58
commit 8a1db50
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/extensions/amp-list/0.1/test/validator-amp-list.html b/extensions/amp-list/0.1/test/validator-amp-list.html
@@ -107,7 +107,7 @@
     src="https://data.com/articles.json?ref=CANONICAL_URL"
     load-more="manual"
     load-more-bookmark="next">
-    <div load-more-button></div>
+    <button load-more-button></button>
     <div load-more-loading></div>
     <div load-more-failed></div>
     <div load-more-end></div>

diff --git a/extensions/amp-list/0.1/test/validator-amp-list.out b/extensions/amp-list/0.1/test/validator-amp-list.out
@@ -112,7 +112,7 @@ amp-list/0.1/test/validator-amp-list.html:85:2 The attribute 'auto-resize' in ta
 |      src="https://data.com/articles.json?ref=CANONICAL_URL"
 |      load-more="manual"
 |      load-more-bookmark="next">
-|      <div load-more-button></div>
+|      <button load-more-button></button>
 |      <div load-more-loading></div>
 |      <div load-more-failed></div>
 |      <div load-more-end></div>

diff --git a/extensions/amp-list/validator-amp-list.protoascii b/extensions/amp-list/validator-amp-list.protoascii
@@ -96,6 +96,9 @@ tags: {  # <amp-list> with mandatory src and/or [src] attr
     deprecation: "[src]"
   }
   attr_lists: "extended-amp-global"
+  reference_points: {
+    tag_spec_name: "AMP-LIST [load-more] items"
+  }
   amp_layout: {
     supported_layouts: FILL
     supported_layouts: FIXED
@@ -107,29 +110,24 @@ tags: {  # <amp-list> with mandatory src and/or [src] attr
 }
 tags: { # amp-list load-more children
   html_format: AMP
-  spec_name: "AMP-LIST LOAD-MORE CHILDREN"
-  tag_name: "DIV"
+  tag_name: "$REFERENCE_POINT"
+  spec_name: "AMP-LIST [load-more] items"
   mandatory_parent: "AMP-LIST"
   attrs: {
     name: "load-more-button"
     value: ""
-    mandatory_oneof: "['load-more-button', 'load-more-failed', 'load-more-end', 'load-more-loading']"
   }
   attrs: {
     name: "load-more-failed"
     value: ""
-    mandatory_oneof: "['load-more-button', 'load-more-failed', 'load-more-end', 'load-more-loading']"
   }
   attrs: {
     name: "load-more-loading"
     value: ""
-    mandatory_oneof: "['load-more-button', 'load-more-failed', 'load-more-end', 'load-more-loading']"
-
   }
   attrs: {
     name: "load-more-end"
     value: ""
-    mandatory_oneof: "['load-more-button', 'load-more-failed', 'load-more-end', 'load-more-loading']"
   }
 }
 # AMP4EMAIL disallows mustache in src attribute.