Skip to content

Commit

Permalink
♻️ Refactor [Colombia Analytics] - Added new parameters and removed u…
Browse files Browse the repository at this point in the history
…nused ones. (#35278)

* add policy attributes

* add owners

* update files for Owners.

* Revert file

* Dmp Analytics event trigger related changes

* Pull request review comments for indentation incorporated

* Indentation corrected and unused code changes removed

* Spaces and newline reveiw comment incorporation done.

* Unit test failure input corrected

* Unit test input data updated

* Indentation corrected
  • Loading branch information
ColombiaOnline committed Aug 4, 2021
1 parent 39689f3 commit 8d1fe37
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
3 changes: 2 additions & 1 deletion extensions/amp-analytics/0.1/test/vendor-requests.json
Expand Up @@ -88,7 +88,8 @@
"colanalytics": {
"host": "https://ase.clmbtech.com",
"base": "https://ase.clmbtech.com/message",
"pageview": "https://ase.clmbtech.com/message?cid=!id&val_101=!id&val_101=_canonical_path_&ch=_canonical_host_&uuid=!uid&au=!authors&zo=!zone&sn=!sponsorName&ct=!contentType&st=_scroll_top_&sh=_scroll_height_&dct=!decayTime&tet=_total_engaged_time_&dr=_document_referrer_&plt=_page_load_time_&val_108=_title_&val_120=3"
"pageview": "https://ase.clmbtech.com/message?cid=!id&val_101=!id&val_101=int%3A_canonical_path_&ch=_canonical_host_&val_108=_title_&val_120=3&val_102=_source_url_&val_124=_external_referrer_&uuid=!uid",
"event": "https://ase.clmbtech.com/message?cid=!id&val_101=!id&val_101=int%3A_canonical_path_&val_101=tet%3A_total_engaged_time_&val_102=clk%3Apg%3A_source_url_"
},
"comscore": {
"host": "https://sb.scorecardresearch.com",
Expand Down
13 changes: 12 additions & 1 deletion extensions/amp-analytics/0.1/vendors/colanalytics.json
Expand Up @@ -2,12 +2,23 @@
"requests": {
"host": "https://ase.clmbtech.com",
"base": "${host}/message",
"pageview": "${base}?cid=${id}&val_101=${id}&val_101=${canonicalPath}&ch=${canonicalHost}&uuid=${uid}&au=${authors}&zo=${zone}&sn=${sponsorName}&ct=${contentType}&st=${scrollTop}&sh=${scrollHeight}&dct=${decayTime}&tet=${totalEngagedTime}&dr=${documentReferrer}&plt=${pageLoadTime}&val_108=${title}&val_120=3"
"pageview": "${base}?cid=${id}&val_101=${id}&val_101=${int}${canonicalPath}&ch=${canonicalHost}&val_108=${title}&val_120=3&val_102=${sourceUrl}&val_124=${externalReferrer}&uuid=${uid}",
"event": "${base}?cid=${id}&val_101=${id}&val_101=${int}${canonicalPath}&val_101=${tet}${totalEngagedTime}&val_102=${clk}${sourceUrl}"
},
"vars": {
"int": "int:",
"clk": "clk:pg:",
"tet": "tet:"
},
"triggers": {
"defaultPageview": {
"on": "visible",
"request": "pageview"
},
"anchorClicks": {
"on": "click",
"selector": "a",
"request": "event"
}
},
"transport": {
Expand Down

0 comments on commit 8d1fe37

Please sign in to comment.