amp-app-banner open url directly in non-embedded chrome ios (#9509)

ampproject · May 24, 2017 · 8d6a125 · 8d6a125
1 parent 95b5a08
commit 8d6a125
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/extensions/amp-app-banner/0.1/amp-app-banner.js b/extensions/amp-app-banner/0.1/amp-app-banner.js
@@ -29,6 +29,7 @@ import {parseUrl} from '../../../src/url';
 import {isProxyOrigin, isProtocolValid} from '../../../src/url';
 
 const TAG = 'amp-app-banner';
+const OPEN_LINK_TIMEOUT = 1500;
 
 /**
  * visible for testing.
@@ -254,10 +255,17 @@ export class AmpIosAppBanner extends AbstractAppBanner {
 
   /** @override */
   openButtonClicked(openInAppUrl, installAppUrl) {
-    timerFor(this.win).delay(() => {
-      this.viewer_.sendMessage('navigateTo', {url: installAppUrl});
-    }, 1500);
-    this.viewer_.sendMessage('navigateTo', {url: openInAppUrl});
+    if (!this.viewer_.isEmbedded()) {
+      timerFor(this.win).delay(() => {
+        openWindowDialog(this.win, installAppUrl, '_top');
+      }, OPEN_LINK_TIMEOUT);
+      openWindowDialog(this.win, openInAppUrl, '_top');
+    } else {
+      timerFor(this.win).delay(() => {
+        this.viewer_.sendMessage('navigateTo', {url: installAppUrl});
+      }, OPEN_LINK_TIMEOUT);
+      this.viewer_.sendMessage('navigateTo', {url: openInAppUrl});
+    }
   }
 
   /**
@@ -380,7 +388,7 @@ export class AmpAndroidAppBanner extends AbstractAppBanner {
   openButtonClicked(openInAppUrl, installAppUrl) {
     timerFor(this.win).delay(() => {
       this.redirectTopLocation_(installAppUrl);
-    }, 1500);
+    }, OPEN_LINK_TIMEOUT);
     openWindowDialog(this.win, openInAppUrl, '_top');
   }