Skip to content

Commit

Permalink
Update Promise PJs (#10762)
Browse files Browse the repository at this point in the history
Fixes #10730.

A very interesting bug where promise adoption (an inner promise being
returned in side a `#then` block causes the outer to adopt the inner)
would not update the state of the outer promise if the inner was still
pending.

This only appeared when:

1. The outer promise was stored, and not used as a larger chain.
2. The inner promise was pending.
3. The outer promise has a `#then` block _after_ the inner promise
  resolved.
  • Loading branch information
jridgewell authored and William Chou committed Aug 2, 2017
1 parent 55f19fc commit 8f3c876
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -26,7 +26,7 @@
},
"dependencies": {
"document-register-element": "1.5.0",
"promise-pjs": "1.1.2",
"promise-pjs": "1.1.3",
"web-animations-js": "2.3.1"
},
"devDependencies": {
Expand Down

0 comments on commit 8f3c876

Please sign in to comment.