Skip to content

Commit

Permalink
Fixed the missing ownerDocument on the container
Browse files Browse the repository at this point in the history
This fixed missing toolbar element classes within the iframe
  • Loading branch information
torch2424 committed Jun 29, 2017
1 parent 37746ce commit 8fe474a
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions extensions/amp-sidebar/1.0/test/test-toolbar.js
Expand Up @@ -25,7 +25,7 @@
const DEFAULT_TOOLBAR_MEDIA = '(min-width: 768px)';

/** @const */
const TOOLBAR_CLASS = 'i-amphtml-toolbar';
const TOOLBAR_ELEMENT_CLASS = 'i-amphtml-toolbar';


adopt(window);
Expand Down Expand Up @@ -111,7 +111,7 @@
const toolbars = obj.toolbars;
const toolbarElements = Array.prototype
.slice.call(obj.toolbarContainerElement.ownerDocument
.getElementsByClassName(TOOLBAR_CLASS), 0);
.getElementsByClassName(TOOLBAR_ELEMENT_CLASS), 0);
resizeIframeToWidth(obj.iframe, '1px', () => {
expect(toolbarElements.length).to.be.above(0);
toolbars.forEach(toolbar => {
Expand All @@ -128,8 +128,8 @@
return getToolbars([{}]).then(obj => {
const toolbars = obj.toolbars;
const toolbarElements = Array.prototype
.slice.call(obj.toolbarContainerElement
.getElementsByClassName(TOOLBAR_CLASS), 0);
.slice.call(obj.toolbarContainerElement.ownerDocument
.getElementsByClassName(TOOLBAR_ELEMENT_CLASS), 0);
resizeIframeToWidth(obj.iframe, '4000px', () => {
expect(toolbarElements.length).to.be.above(0);
toolbars.forEach(toolbar => {
Expand All @@ -146,8 +146,8 @@
return getToolbars([{}]).then(obj => {
const toolbars = obj.toolbars;
const toolbarElements = Array.prototype
.slice.call(obj.toolbarContainerElement
.getElementsByClassName(TOOLBAR_CLASS), 0);
.slice.call(obj.toolbarContainerElement.ownerDocument
.getElementsByClassName(TOOLBAR_ELEMENT_CLASS), 0);
resizeIframeToWidth(obj.iframe, '4000px', () => {
expect(toolbarElements.length).to.be.above(0);
toolbars.forEach(toolbar => {
Expand All @@ -164,8 +164,8 @@
return getToolbars([{}]).then(obj => {
const toolbars = obj.toolbars;
const toolbarElements = Array.prototype
.slice.call(obj.toolbarContainerElement
.getElementsByClassName(TOOLBAR_CLASS), 0);
.slice.call(obj.toolbarContainerElement.ownerDocument
.getElementsByClassName(TOOLBAR_ELEMENT_CLASS), 0);
resizeIframeToWidth(obj.iframe, '4000px', () => {
toolbars.forEach(toolbar => {
toolbar.onLayoutChange();
Expand All @@ -188,7 +188,7 @@
const toolbars = obj.toolbars;
const toolbarElements = Array.prototype
.slice.call(obj.toolbarContainerElement.ownerDocument
.getElementsByClassName(TOOLBAR_CLASS), 0);
.getElementsByClassName(TOOLBAR_ELEMENT_CLASS), 0);
resizeIframeToWidth(obj.iframe, '1px', () => {
expect(toolbarElements.length).to.be.above(0);
toolbars.forEach(toolbar => {
Expand Down

0 comments on commit 8fe474a

Please sign in to comment.