enable typechecking for the babel-plugin directory (#35574)

* babel plugins: enable typechecking

* @ts-nocheck everywhere

build-system/babel-plugins/babel-plugin-amp-mode-transformer/index.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
 /**
  * Changes the values of getMode().test, getMode().localDev to false

build-system/babel-plugins/babel-plugin-const-transformer/index.js

@@ -13,7 +13,13 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
+/**
+ * @interface {babel.PluginPass}
+ * @param {babel} babel
+ * @return {babel.PluginObj}
+ */
 module.exports = function ({types: t}) {
   return {
     visitor: {

build-system/babel-plugins/babel-plugin-imported-helpers/index.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
 const {addDefault} = require('@babel/helper-module-imports');
 

build-system/babel-plugins/babel-plugin-transform-amp-asserts/index.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
 const typeMap = {
   'assertElement': 'Element',

build-system/babel-plugins/babel-plugin-transform-amp-extension-call/index.js

@@ -13,7 +13,13 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
+/**
+ * @interface {babel.PluginPass}
+ * @param {babel} babel
+ * @return {babel.PluginObj}
+ */
 module.exports = function (babel) {
   const {types: t} = babel;
   return {

build-system/babel-plugins/babel-plugin-transform-annotation-to-extern/index.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
 // Global typedef map typedefName: typedef comment
 const TYPEDEFS = new Map();

build-system/babel-plugins/babel-plugin-transform-default-assignment/index.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
 /**
  * Injects alias identifiers for values with default assignments.

build-system/babel-plugins/babel-plugin-transform-dev-methods/index.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
 const {dirname, join, relative, resolve} = require('path').posix;
 

build-system/babel-plugins/babel-plugin-transform-fix-leading-comments/index.js

@@ -13,10 +13,16 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
-// Reassigns the trailing comments of a statement to be leading comment of its
-// next sibling. This is because JSDoc comments (which should be on the next
-// statement) get erroneously assigned as trailing comments of this statement.
+/**
+ * Reassigns the trailing comments of a statement to be leading comment of its
+ * next sibling. This is because JSDoc comments (which should be on the next
+ * statement) get erroneously assigned as trailing comments of this statement.
+ *
+ * @interface {babel.PluginPass}
+ * @return {babel.PluginObj}
+ */
 module.exports = function () {
   return {
     visitor: {

build-system/babel-plugins/babel-plugin-transform-function-declarations/index.js

@@ -13,9 +13,15 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
-// Attempt to convert simple single ReturnStatement FunctionDeclarations to ArrowFunctionExpressions.
-// See BAIL_OUT_CONDITIONS for reasons why FunctionDeclarations would not be modified.
+/**
+ * Attempt to convert simple single ReturnStatement FunctionDeclarations to ArrowFunctionExpressions.
+ * See BAIL_OUT_CONDITIONS for reasons why FunctionDeclarations would not be modified.
+ * @interface {babel.PluginPass}
+ * @param {babel} babel
+ * @return {babel.PluginObj}
+ */
 module.exports = function ({types: t}) {
   /**
    * This transform is targetted toward these types only.

build-system/babel-plugins/babel-plugin-transform-html-template/index.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
 const {
   staticTemplateFactoryFns,

build-system/babel-plugins/babel-plugin-transform-inline-isenumvalue/index.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
 const {dirname, join: joinPath, relative} = require('path');
 const {readFileSync} = require('fs');

build-system/babel-plugins/babel-plugin-transform-json-configuration/index.js

@@ -13,7 +13,13 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
+/**
+ * @interface {babel.PluginPass}
+ * @param {babel} babel
+ * @return {babel.PluginObj}
+ */
 module.exports = function ({template, types: t}) {
   /**
    * Produces a random number that is guaranteed not to be present in str.

build-system/babel-plugins/babel-plugin-transform-json-import/index.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
 const {dirname, join, relative, resolve} = require('path');
 const {readFileSync} = require('fs');

build-system/babel-plugins/babel-plugin-transform-jss/index.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
 /**
  * Takes a .jss.js file and transforms the `useStyles` export to remove side effects

build-system/babel-plugins/babel-plugin-transform-log-methods/index.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
 /**
  * @fileoverview Indirects log messages through expansion calls with

build-system/babel-plugins/babel-plugin-transform-minified-comments/index.js

@@ -13,8 +13,14 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
-// Ensure comments in minified build output is minimal.
+/**
+ * Ensure comments in minified build output is minimal.
+ *
+ * @interface {babel.PluginPass}
+ * @return {babel.PluginObj}
+ */
 module.exports = function () {
   return {
     visitor: {

build-system/babel-plugins/babel-plugin-transform-parenthesize-expression/index.js

@@ -13,7 +13,13 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
+/**
+ * @interface {babel.PluginPass}
+ * @param {babel} babel
+ * @return {babel.PluginObj}
+ */
 module.exports = function (babel) {
   const {types: t} = babel;
   return {

build-system/babel-plugins/babel-plugin-transform-promise-resolve/index.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
 const pathmodule = require('path');
 const {addNamed} = require('@babel/helper-module-imports');

build-system/babel-plugins/babel-plugin-transform-prune-namespace/index.js

@@ -13,7 +13,12 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
+/**
+ * @interface {babel.PluginPass}
+ * @return {babel.PluginObj}
+ */
 module.exports = function () {
   const namespace = '_';
 

build-system/babel-plugins/babel-plugin-transform-remove-directives/index.js

@@ -13,7 +13,12 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
+/**
+ * @interface {babel.PluginPass}
+ * @return {babel.PluginObj}
+ */
 module.exports = function () {
   return {
     name: 'remove-strict-directives',

build-system/babel-plugins/babel-plugin-transform-simple-array-destructure/index.js

@@ -13,7 +13,13 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
+/**
+ * @interface {babel.PluginPass}
+ * @param {babel} babel
+ * @return {babel.PluginObj}
+ */
 module.exports = function (babel) {
   const {types: t} = babel;
 

build-system/babel-plugins/babel-plugin-transform-stringish-literals/index.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
 const ESCAPE_REGEX = /\${|\\|`/g;
 

build-system/babel-plugins/log-module-metadata.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
 /** @fileoverview Definitions of logging methods for transforms and linting. */
 

build-system/babel-plugins/static-template-metadata.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// @ts-nocheck
 
 /** Metadata for static template functions `htmlFor` and `svgFor`. */
 

build-system/tsconfig.json

@@ -33,7 +33,7 @@
     "./**/node_modules/**",
     "./**/test/**/*.js",
     "./**/*test*.js",
-    "./babel-plugins/**/*.js",
+    "./babel-plugins/**/(input|output).js",
     "./eslint-rules/**/*.js",
     "./externs/**/*.js",
     "./tasks/make-extension/template/**/*.js",