Don't allow other fast fetch impls to import doubleclick or adsense i…

…mpls. (#12101) * Don't allow anyone, for any reason, ever, no matter who, no matter who you are with, to extend doubleclick impl or adsense impl * Don't let any files depend
ampproject · Dec 6, 2017 · 97072fb · 97072fb
1 parent cd23566
commit 97072fb
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/build-system/dep-check-config.js b/build-system/dep-check-config.js
@@ -251,4 +251,11 @@ exports.rules = [
       'src/iframe-helper.js',
     ],
   },
+
+  {
+    mustNotDependOn: [
+      'extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js',
+      'extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js',
+    ],
+  },
 ];
diff --git a/extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js b/extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js
@@ -83,6 +83,7 @@ export function resetSharedState() {
   sharedState.reset();
 }
 
+/** @final */
 export class AmpAdNetworkAdsenseImpl extends AmpA4A {
 
   /**

diff --git a/extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js b/extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js
@@ -279,6 +279,7 @@ function fluidMessageListener_(event) {
   listener.instance.receiveMessageForFluid_(payload);
 }
 
+/** @final */
 export class AmpAdNetworkDoubleclickImpl extends AmpA4A {
 
   /**