babel: teach amp mode transformer about #core/mode (#35477)

* babel: teach amp mode transformer about #core/mode * jridgewell babel feedback
ampproject · Aug 3, 2021 · a6893a0 · a6893a0
1 parent 60eba27
commit a6893a0
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 2 deletions.
diff --git a/build-system/babel-plugins/babel-plugin-amp-mode-transformer/index.js b/build-system/babel-plugins/babel-plugin-amp-mode-transformer/index.js
@@ -51,7 +51,7 @@ module.exports = function ({types: t}) {
         const {node} = path;
         const {object: obj, property} = node;
         const {callee} = obj;
-        const {INTERNAL_RUNTIME_VERSION} = this.opts;
+        const {INTERNAL_RUNTIME_VERSION: version} = this.opts;
 
         if (callee && callee.name === 'getMode') {
           if (property.name === 'test' || property.name === 'localDev') {
@@ -61,10 +61,16 @@ module.exports = function ({types: t}) {
           } else if (property.name === 'minified') {
             path.replaceWith(t.booleanLiteral(true));
           } else if (property.name === 'version') {
-            path.replaceWith(t.stringLiteral(INTERNAL_RUNTIME_VERSION));
+            path.replaceWith(t.stringLiteral(version));
           }
         }
       },
+      CallExpression(path) {
+        const {INTERNAL_RUNTIME_VERSION: version} = this.opts;
+        if (path.get('callee').referencesImport('#core/mode', 'version')) {
+          path.replaceWith(t.stringLiteral(version));
+        }
+      },
     },
   };
 };
diff --git a/...abel-plugin-amp-mode-transformer/test/fixtures/transform-assertions/no-transform/input.js b/...abel-plugin-amp-mode-transformer/test/fixtures/transform-assertions/no-transform/input.js
@@ -18,6 +18,7 @@ const test = getMode().test;
 const localDev = getMode().localDev;
 const minified = getMode().minified;
 const development = getMode().development;
+const namespaceVersion = mode.version();
 
 function getMode() {
   return {};

diff --git a/...bel-plugin-amp-mode-transformer/test/fixtures/transform-assertions/no-transform/output.js b/...bel-plugin-amp-mode-transformer/test/fixtures/transform-assertions/no-transform/output.js
@@ -17,6 +17,7 @@ const test = getMode().test;
 const localDev = getMode().localDev;
 const minified = getMode().minified;
 const development = getMode().development;
+const namespaceVersion = mode.version();
 
 function getMode() {
   return {};

diff --git a/...s/babel-plugin-amp-mode-transformer/test/fixtures/transform-assertions/transform/input.js b/...s/babel-plugin-amp-mode-transformer/test/fixtures/transform-assertions/transform/input.js
@@ -15,12 +15,14 @@
  */
 
 import { getMode } from '../../../../../../../src/mode';
+import * as mode from '#core/mode';
 
 const test = getMode().test;
 const localDev = getMode().localDev;
 const minified = getMode().minified;
 const development = getMode().development;
 const version = getMode().version;
+const namespaceVersion = mode.version();
 
 function foo() {
   if (getMode().development == false) {

diff --git a/...babel-plugin-amp-mode-transformer/test/fixtures/transform-assertions/transform/output.mjs b/...babel-plugin-amp-mode-transformer/test/fixtures/transform-assertions/transform/output.mjs
@@ -14,11 +14,13 @@
  * limitations under the License.
  */
 import { getMode } from '../../../../../../../src/mode';
+import * as mode from '#core/mode';
 const test = false;
 const localDev = false;
 const minified = true;
 const development = false;
 const version = "$internalRuntimeVersion$";
+const namespaceVersion = "$internalRuntimeVersion$";
 
 function foo() {
   if (false == false) {