Skip to content

Commit

Permalink
Fix ad-3p test flakes due to isBuilt stubbing (#32542)
Browse files Browse the repository at this point in the history
  • Loading branch information
Dima Voytenko committed Feb 9, 2021
1 parent 6ae6dbc commit a876a6b
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion extensions/amp-ad/0.1/test/test-amp-ad-3p-impl.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,11 @@ function createAmpAd(win, attachToAmpdoc = false, ampdoc) {
return true;
};

return new AmpAd3PImpl(ampAdElement);
const impl = new AmpAd3PImpl(ampAdElement);
// Initialize internal implementation structure since `isBuilt` is forced
// to return `true` above.
ampAdElement.impl_ = impl;
return impl;
}

describes.realWin(
Expand Down

0 comments on commit a876a6b

Please sign in to comment.