✨ amp-connatix-player: add support for custom data param (#37332)

* add support for custom data param * fix lint
ampproject · Feb 7, 2022 · ac061f2 · ac061f2
1 parent 8f24c06
commit ac061f2
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/extensions/amp-connatix-player/0.1/amp-connatix-player.js b/extensions/amp-connatix-player/0.1/amp-connatix-player.js
@@ -3,7 +3,7 @@ import {
   CONSENT_STRING_TYPE,
 } from '#core/constants/consent-state';
 import {Deferred} from '#core/data-structures/promise';
-import {removeElement} from '#core/dom';
+import {getDataParamsFromAttributes, removeElement} from '#core/dom';
 import {applyFillContent, isLayoutSizeDefined} from '#core/dom/layout';
 import {
   observeContentSize,
@@ -272,6 +272,7 @@ export class AmpConnatixPlayer extends AMP.BaseElement {
       'playerId': this.playerId_ || undefined,
       'mediaId': this.mediaId_ || undefined,
       'url': Services.documentInfoForDoc(element).sourceUrl,
+      ...getDataParamsFromAttributes(element),
     };
     const iframeUrl = this.iframeDomain_ + '/amp-embed/index.html';
     const src = addParamsToUrl(iframeUrl, urlParams);

diff --git a/extensions/amp-connatix-player/0.1/test/test-amp-connatix-player.js b/extensions/amp-connatix-player/0.1/test/test-amp-connatix-player.js
@@ -69,6 +69,18 @@ describes.realWin(
         'https://cdm.elements.video/amp-embed/index.html?playerId=f721b0d8-7a79-42b6-b637-fa4e86138ed9&url=about%3Asrcdoc'
       );
     });
+    it('should pass data-param-* attributes to the iframe src', async () => {
+      const cnx = await getConnatixPlayer({
+        'data-player-id': 'f721b0d8-7a79-42b6-b637-fa4e86138ed9',
+        'data-param-my-param': 17,
+      });
+      const iframe = cnx.querySelector('iframe');
+      expect(iframe).to.not.be.null;
+      expect(iframe.tagName).to.equal('IFRAME');
+      expect(iframe.src).to.equal(
+        'https://cdm.connatix.com/amp-embed/index.html?playerId=f721b0d8-7a79-42b6-b637-fa4e86138ed9&url=about%3Asrcdoc&myParam=17'
+      );
+    });
 
     it('fails if no playerId is specified', () => {
       return allowConsoleError(() => {

diff --git a/extensions/amp-connatix-player/amp-connatix-player.md b/extensions/amp-connatix-player/amp-connatix-player.md
@@ -38,6 +38,10 @@ Connatix management dashboard.
 Connatix media id. This represents the unique ID of any media in your Library.
 This can be found at the Library section in the Connatix management dashboard.
 
+### data-param-\*
+
+All `data-param-*` prefixed attributes are turned into URL parameters and passed to iframe src.
+
 ### Common attributes
 
 This element includes [common attributes](https://amp.dev/documentation/guides-and-tutorials/learn/common_attributes)