Skip to content

Commit

Permalink
Remove code for inabox chunking experiments
Browse files Browse the repository at this point in the history
  • Loading branch information
powerivq committed Sep 23, 2019
1 parent b8ab270 commit acfdec2
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 13 deletions.
1 change: 0 additions & 1 deletion build-system/global-configs/canary-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"allow-doc-opt-in": [
"amp-next-page",
"inabox-viewport-friendly",
"inabox-no-chunking",
"inabox-resources-lite",
"inabox-viewer-lite",
"inabox-viewport-lite"
Expand Down
1 change: 0 additions & 1 deletion build-system/global-configs/prod-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"allow-doc-opt-in": [
"amp-next-page",
"inabox-viewport-friendly",
"inabox-no-chunking",
"inabox-resources-lite",
"inabox-viewer-lite",
"inabox-viewport-lite"
Expand Down
2 changes: 1 addition & 1 deletion examples/amphtml-ads/many-ads.host.html
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ <h3>Text ad</h3>
src="//ads.localhost:8000/examples/amphtml-ads/text-ad.a4a.html"
scrolling="no">
</iframe>
<a href="/inabox/examples/amphtml-ads/text-ad.a4a.html?exp=inabox-no-chunking" target="_blank">open in new tab</a>
<a href="/inabox/examples/amphtml-ads/text-ad.a4a.html" target="_blank">open in new tab</a>
<hr>
<h3>GIF ad</h3>
<iframe
Expand Down
4 changes: 0 additions & 4 deletions src/inabox/amp-inabox.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@ try {
// Should happen first.
installErrorReporting(self); // Also calls makeBodyVisibleRecovery on errors.

if (isExperimentOn(self, 'inabox-no-chunking')) {
deactivateChunking();
}

// Declare that this runtime will support a single root doc. Should happen
// as early as possible.
installDocService(self, /* isSingleDoc */ true);
Expand Down
6 changes: 0 additions & 6 deletions tools/experiments/experiments.js
Original file line number Diff line number Diff line change
Expand Up @@ -323,12 +323,6 @@ const EXPERIMENTS = [
spec: 'https://github.com/ampproject/amphtml/issues/22418',
cleanupIssue: 'https://github.com/ampproject/amphtml/issues/22418',
},
{
id: 'inabox-no-chunking',
name: 'Experiment to disable startup chunking in inabox runtime',
spec: 'https://github.com/ampproject/amphtml/issues/23573',
cleanupIssue: 'https://github.com/ampproject/amphtml/issues/23573',
},
{
id: 'amp-user-location',
name:
Expand Down

0 comments on commit acfdec2

Please sign in to comment.