Skip to content

Commit

Permalink
Validator rollup
Browse files Browse the repository at this point in the history
cl/356380828 Improve html5 parsing. (#32555)

Co-authored-by: Amaltas Bohra <amaltas@google.com>
  • Loading branch information
MichaelRybak and amaltas committed Feb 9, 2021
1 parent 2ca31c4 commit b02cf8b
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 16 deletions.
4 changes: 2 additions & 2 deletions validator/testdata/amp4ads_feature_tests/doctype.out.cpponly
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ FAIL
| Only html attribute is allowed in <!doctype> declaration.
| -->
| <!doctype html data-foo id=doctype>
>> ^~~~~~~~~
amp4ads_feature_tests/doctype.html:20:12 Invalid or missing doctype declaration. Should be '!doctype html'. (see https://amp.dev/documentation/guides-and-tutorials/start/create/basic_markup/)
>> ^~~~~~~~~
amp4ads_feature_tests/doctype.html:20:10 Invalid or missing doctype declaration. Should be '!doctype html'. (see https://amp.dev/documentation/guides-and-tutorials/start/create/basic_markup/)
| <html ⚡4ads>
| <head>
| <meta charset="utf-8">
Expand Down
12 changes: 6 additions & 6 deletions validator/testdata/feature_tests/leaks.out.cpponly
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ FAIL
| All of these test cases should produce errors.
| -->
| <!doctype html SYSTEM "https://leaking.via/doctype">
>> ^~~~~~~~~
feature_tests/leaks.html:24:12 Invalid or missing doctype declaration. Should be '!doctype html'. (see https://amp.dev/documentation/guides-and-tutorials/start/create/basic_markup/)
>> ^~~~~~~~~
feature_tests/leaks.html:24:12 The attribute 'system' may not appear in tag 'html !doctype'. (see https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup)
>> ^~~~~~~~~
feature_tests/leaks.html:24:10 Invalid or missing doctype declaration. Should be '!doctype html'. (see https://amp.dev/documentation/guides-and-tutorials/start/create/basic_markup/)
>> ^~~~~~~~~
feature_tests/leaks.html:24:10 The attribute 'system' may not appear in tag 'html !doctype'. (see https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup)
|
| <html ⚡ manifest="https://leaking.via/html-manifest">
>> ^~~~~~~~~
Expand Down Expand Up @@ -343,8 +343,8 @@ feature_tests/leaks.html:193:4 The tag 'feimage' is disallowed.
| -->
| <?xml-stylesheet type="text/xsl" href="https://leaking.via/xslt-stylesheet" ?>
|
>> ^~~~~~~~~
feature_tests/leaks.html:200:1 The tag '<?' is disallowed.
>> ^~~~~~~~~
feature_tests/leaks.html:200:2 The tag '<?' is disallowed.
| <!--
| %Data Islands
| -->
Expand Down
16 changes: 8 additions & 8 deletions validator/testdata/feature_tests/parser.out.cpponly
Original file line number Diff line number Diff line change
Expand Up @@ -100,18 +100,18 @@ feature_tests/parser.html:59:2 The attribute 'a' may not appear in tag 'a'. (see
| <!-- Tags that may be processing instructions: -->
| <?php ?>
| < ?php ?>
>> ^~~~~~~~~
feature_tests/parser.html:63:3 The tag '<?' is disallowed.
>> ^~~~~~~~~
feature_tests/parser.html:63:4 The tag '<?' is disallowed.
| <?php echo 'Hello, World'; ?>
| <?php <span>Content</span> ?>
>> ^~~~~~~~~
feature_tests/parser.html:65:3 The tag '<?' is disallowed.
>> ^~~~~~~~~
feature_tests/parser.html:65:4 The tag '<?' is disallowed.
| <?xml:namespace prefix = o ns = "urn:schemas-microsoft-com:office:office" />
>> ^~~~~~~~~
feature_tests/parser.html:66:3 The tag '<?' is disallowed.
>> ^~~~~~~~~
feature_tests/parser.html:66:4 The tag '<?' is disallowed.
| < ?xml:namespace ?>
>> ^~~~~~~~~
feature_tests/parser.html:67:3 The tag '<?' is disallowed.
>> ^~~~~~~~~
feature_tests/parser.html:67:4 The tag '<?' is disallowed.
|
| </body>
| </html>

0 comments on commit b02cf8b

Please sign in to comment.