Skip to content

Commit

Permalink
Added twitter to the tabbables (#33919)
Browse files Browse the repository at this point in the history
  • Loading branch information
mszylkowski committed Apr 20, 2021
1 parent 90a0396 commit b55a12a
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
13 changes: 11 additions & 2 deletions examples/amp-story/show-tooltip.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<head>
<meta charset="utf-8">
<script async src="https://cdn.ampproject.org/v0.js"></script>
<script async custom-element="amp-story"
src="https://cdn.ampproject.org/v0/amp-story-1.0.js"></script>
<script async custom-element="amp-story" src="https://cdn.ampproject.org/v0/amp-story-1.0.js"></script>
<script async custom-element="amp-twitter" src="https://cdn.ampproject.org/v0/amp-twitter-0.1.js"></script>
<title>My Story</title>
<meta name="description" content="Get started with amp-story">

Expand Down Expand Up @@ -58,6 +58,15 @@ <h1>fill</h1>
</amp-story-grid-layer>
</amp-story-page>

<amp-story-page id="twitter">
<amp-story-grid-layer>
<amp-twitter width="375" height="472"
layout="responsive"
data-tweetid="638793490521001985" interactive>
</amp-twitter>
</amp-story-grid-layer>
</amp-story-page>

</amp-story>
</body>
</html>
2 changes: 1 addition & 1 deletion extensions/amp-story/1.0/amp-story-page.js
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export const Selectors = {
ALL_PLAYBACK_MEDIA:
'> audio, amp-story-grid-layer audio, amp-story-grid-layer video',
ALL_VIDEO: 'amp-story-grid-layer video',
ALL_TABBABLE: 'a',
ALL_TABBABLE: 'a, amp-twitter > iframe',
};

/** @private @const {string} */
Expand Down

0 comments on commit b55a12a

Please sign in to comment.