🏗 Allow IE integration tests to block the build (#30397)

* Let IE integration tests block the build

* clean up unused helpers

* add dev assert around createFixtureIframe height

build-system/pr-check/cross-browser-tests.js

@@ -28,12 +28,10 @@ const {
   startTimer,
   stopTimer,
   timedExecOrDie: timedExecOrDieBase,
-  timedExec: timedExecBase,
 } = require('./utils');
 
 const FILENAME = 'cross-browser-tests.js';
 const timedExecOrDie = (cmd) => timedExecOrDieBase(cmd, FILENAME);
-const timedExec = (cmd) => timedExecBase(cmd, FILENAME);
 
 async function main() {
   const startTime = startTimer(FILENAME, FILENAME);
@@ -54,8 +52,7 @@ async function main() {
     case 'win32':
       timedExecOrDie('gulp unit --nobuild --headless --edge');
       timedExecOrDie('gulp integration --nobuild --compiled --headless --edge');
-      // TODO(rsimha): Fix all IE tests and make this task fail the build.
-      timedExec('gulp integration --nobuild --compiled --ie');
+      timedExecOrDie('gulp integration --nobuild --compiled --ie');
       break;
     default:
       log(

testing/iframe.js

@@ -22,6 +22,7 @@ import {Services} from '../src/services';
 import {cssText as ampDocCss} from '../build/ampdoc.css';
 import {cssText as ampSharedCss} from '../build/ampshared.css';
 import {deserializeMessage, isAmpMessage} from '../src/3p-frame-messaging';
+import {dev} from '../src/log';
 import {
   installAmpdocServices,
   installRuntimeServices,
@@ -65,6 +66,10 @@ export function createFixtureIframe(
   initialIframeHeight,
   opt_beforeLoad
 ) {
+  dev().assertNumber(
+    initialIframeHeight,
+    'Attempted to create fixture iframe with non-numeric height'
+  );
   return new Promise((resolve, reject) => {
     // Counts the supported custom events.
     const events = {