-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🐛 Fix video pausing itself after second layout (#32220)
Fixes #32173 1. When closing a container lightbox, the `<amp-youtube>` element is unlaid out. 2. When opening the lightbox a second time, the `<amp-youtube>` element is laid out again. The `VideoManager` then incorrectly stores two entries. When playing for a second time it will `pauseOtherVideos()`, incorrectly pausing itself—so the video never plays. The reused `VideoEntry` maintains its listeners at the e.g. `<amp-video>` level, so they continue to work.
- Loading branch information
1 parent
f41acfb
commit beac005
Showing
2 changed files
with
28 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters