Skip test on old chrome (#8968)

ampproject · Apr 27, 2017 · c0be98e · c0be98e
1 parent f5a864a
commit c0be98e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/extensions/amp-ad/0.1/test/test-amp-ad-3p-impl.js b/extensions/amp-ad/0.1/test/test-amp-ad-3p-impl.js
@@ -179,8 +179,10 @@ describe('amp-ad-3p-impl', () => {
     });
   });
 
+  // TODO(#8965) unskip test
   describe('preconnectCallback', () => {
-    it('should add preconnect and prefech to DOM header', () => {
+    it.configure().skipOldChrome()
+    .run('should add preconnect and prefech to DOM header', () => {
       ad3p.buildCallback();
       ad3p.preconnectCallback();
       return whenFirstVisible.then(() => {

diff --git a/extensions/amp-ad/0.1/test/test-amp-ad-xorigin-iframe-handler.js b/extensions/amp-ad/0.1/test/test-amp-ad-xorigin-iframe-handler.js
@@ -258,7 +258,9 @@ describe('amp-ad-xorigin-iframe-handler', () => {
       iframeHandler.init(iframe);
     });
 
-    it('should be able to use embed-state API', () => {
+    // TODO(#8965) unskip test
+    it.configure().skipOldChrome()
+    .run('should be able to use embed-state API', () => {
       iframe.postMessageToParent({
         type: 'send-embed-state',
         sentinel: 'amp3ptest' + testIndex,

diff --git a/test/_init_tests.js b/test/_init_tests.js
@@ -106,6 +106,12 @@ class TestConfig {
     return this.skip(this.platform.isChrome.bind(this.platform));
   }
 
+  skipOldChrome() {
+    return this.skip(() => {
+      return this.platform.isChrome() && this.platform.getMajorVersion() < 48;
+    });
+  }
+
   skipEdge() {
     return this.skip(this.platform.isEdge.bind(this.platform));
   }