Skip to content

Commit

Permalink
🐛 [bento-app-banner] Fixed build configurations (#37571)
Browse files Browse the repository at this point in the history 
* feature(bento-app-banner): moved component to top-level folder

* feature(bento-app-banner): added `"npm": true` to app-banner

* feature(bento-list): fixed prettify formatting

Co-authored-by: scottrippey <scott.william.rippey@gmail.com>
  • Loading branch information
@scottrippey
scottrippey and scottrippey committed Feb 4, 2022
1 parent adadff7 commit c9aaf96
Show file tree
Hide file tree
Showing 12 changed files with 12 additions and 11 deletions.
1 change: 1 addition & 0 deletions build-system/compile/bundles.config.extensions.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@
"version": "1.0",
"options": {
"hasCss": true,
"npm": true,
"bento": true
}
},
Expand Down
6 changes: 3 additions & 3 deletions css/Z_INDEX.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@
| `amp-mega-menu` | 1000 | [extensions/amp-mega-menu/0.1/amp-mega-menu.css](/extensions/amp-mega-menu/0.1/amp-mega-menu.css) |
| `amp-user-notification` | 1000 | [extensions/amp-user-notification/0.1/amp-user-notification.css](/extensions/amp-user-notification/0.1/amp-user-notification.css) |
| `i-amphtml-app-banner-top-padding` | 15 | [extensions/amp-app-banner/0.1/amp-app-banner.css](/extensions/amp-app-banner/0.1/amp-app-banner.css) |
| `bannerPadding` | 15 | [extensions/amp-app-banner/1.0/component/component.jss.js](/extensions/amp-app-banner/1.0/component/component.jss.js) |
| `bannerPadding` | 15 | [extensions/amp-app-banner/1.0/component.jss.js](/extensions/amp-app-banner/1.0/component.jss.js) |
| `.amp-app-banner-dismiss-button` | 14 | [extensions/amp-app-banner/0.1/amp-app-banner.css](/extensions/amp-app-banner/0.1/amp-app-banner.css) |
| `dismiss` | 14 | [extensions/amp-app-banner/1.0/component/component.jss.js](/extensions/amp-app-banner/1.0/component/component.jss.js) |
| `dismiss` | 14 | [extensions/amp-app-banner/1.0/component.jss.js](/extensions/amp-app-banner/1.0/component.jss.js) |
| `amp-app-banner` | 13 | [extensions/amp-app-banner/0.1/amp-app-banner.css](/extensions/amp-app-banner/0.1/amp-app-banner.css) |
| `amp-app-banner` | 13 | [extensions/amp-app-banner/1.0/amp-app-banner.css](/extensions/amp-app-banner/1.0/amp-app-banner.css) |
| `banner` | 13 | [extensions/amp-app-banner/1.0/component/component.jss.js](/extensions/amp-app-banner/1.0/component/component.jss.js) |
| `banner` | 13 | [extensions/amp-app-banner/1.0/component.jss.js](/extensions/amp-app-banner/1.0/component.jss.js) |
| `amp-sticky-ad-top-padding` | 12 | [extensions/amp-sticky-ad/1.0/amp-sticky-ad.css](/extensions/amp-sticky-ad/1.0/amp-sticky-ad.css) |
| `style` | 11 | [extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js](/extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js) |
| `amp-sticky-ad` | 11 | [extensions/amp-sticky-ad/1.0/amp-sticky-ad.css](/extensions/amp-sticky-ad/1.0/amp-sticky-ad.css) |
Expand Down
4 changes: 2 additions & 2 deletions extensions/amp-app-banner/1.0/base-element.js
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {PreactBaseElement} from '#preact/base-element';

import {BentoAppBanner} from './component/component';
import {CSS as COMPONENT_CSS} from './component/component.jss';
import {BentoAppBanner} from './component';
import {CSS as COMPONENT_CSS} from './component.jss';

export class BaseElement extends PreactBaseElement {}

Expand Down
4 changes: 2 additions & 2 deletions ...amp-app-banner/1.0/component/component.js → extensions/amp-app-banner/1.0/component.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import {useLocalStorage} from '#preact/hooks/useLocalStorage';
import {logger} from '#preact/logger';
import {platformUtils} from '#preact/utils/platform';

import {getAndroidAppInfo} from './android';
import {useStyles} from './component.jss';
import {getIOSAppInfo} from './ios';
import {getAndroidAppInfo} from './utils/android';
import {getIOSAppInfo} from './utils/ios';

/**
* The raw App Banner component; no platform-specific logic
Expand Down
0 ...app-banner/1.0/component/component.jss.js → ...sions/amp-app-banner/1.0/component.jss.js
View file
File renamed without changes.
0 ...pp-banner/1.0/component/component.type.js → ...ions/amp-app-banner/1.0/component.type.js
View file
File renamed without changes.
2 changes: 1 addition & 1 deletion extensions/amp-app-banner/1.0/storybook/Basic.js
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as Preact from '#preact';

import {AppBanner} from '../component/component';
import {AppBanner} from '../component';

// TODO: use something like storybook actions instead of console.log:
// eslint-disable-next-line local/no-forbidden-terms
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-app-banner/1.0/test/test-android.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {docInfo} from '#preact/utils/docInfo';
import {platformUtils} from '#preact/utils/platform';
import {xhrUtils} from '#preact/utils/xhr';

import {getAndroidAppInfo} from '../component/android';
import {getAndroidAppInfo} from '../utils/android';

describes.sandboxed('BentoAppBanner preact component v1.0', {}, (env) => {
let xhrServiceStub;
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-app-banner/1.0/test/test-component.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {mount} from 'enzyme';
import * as Preact from '#preact';
import {platformUtils} from '#preact/utils/platform';

import {AppBanner, BentoAppBanner} from '../component/component';
import {AppBanner, BentoAppBanner} from '../component';

describes.realWin('BentoAppBanner preact component v1.0', {}, (env) => {
describe('raw AppBanner', () => {
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-app-banner/1.0/test/test-ios.js
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {logger} from '#preact/logger';
import {platformUtils} from '#preact/utils/platform';

import {getIOSAppInfo} from '../component/ios';
import {getIOSAppInfo} from '../utils/ios';

describes.sandboxed('BentoAppBanner preact component v1.0', {}, (env) => {
describe('getIOSAppInfo', () => {
Expand Down
0 ...s/amp-app-banner/1.0/component/android.js → ...sions/amp-app-banner/1.0/utils/android.js
View file
File renamed without changes.
0 ...sions/amp-app-banner/1.0/component/ios.js → extensions/amp-app-banner/1.0/utils/ios.js
View file
File renamed without changes.

0 comments on commit c9aaf96

Please sign in to comment.