Skip to content

Commit

Permalink
amp-next-page: Fetch failure should be a user error (#22293)
Browse files Browse the repository at this point in the history
* Fetch failure should be a user error.

* Minor clean up.

* Fix lint.

* Don't append empty docs.

* Just make the minimal change. :)
  • Loading branch information
William Chou committed May 15, 2019
1 parent e20dc1a commit cc8867b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions extensions/amp-next-page/0.1/next-page-service.js
Expand Up @@ -20,7 +20,7 @@ import {
PositionObserverFidelity,
} from '../../../src/service/position-observer/position-observer-worker';
import {Services} from '../../../src/services';
import {dev, userAssert} from '../../../src/log';
import {dev, user, userAssert} from '../../../src/log';
import {dict} from '../../../src/utils/object';
import {getAmpdoc, getServiceForDoc} from '../../../src/service';
import {
Expand Down Expand Up @@ -311,7 +311,7 @@ export class NextPageService {
}
});
}),
e => dev().error(TAG, 'failed to fetch %s', next.ampUrl, e))
e => user().error(TAG, 'failed to fetch %s', next.ampUrl, e))
.catch(e => dev().error(TAG,
'failed to attach shadow document for %s', next.ampUrl, e))
// The new page may be short and the next may already need fetching.
Expand Down

0 comments on commit cc8867b

Please sign in to comment.