cookie: Minor test improvement (#26922)

Expect console errors.
ampproject · Feb 24, 2020 · d01263b · d01263b
1 parent ff098aa
commit d01263b
Showing 1 changed file with 17 additions and 7 deletions.
diff --git a/test/unit/test-cookies.js b/test/unit/test-cookies.js
@@ -199,29 +199,39 @@ describes.fakeWin('test-cookies', {amp: true}, env => {
 
     // Fail if allowOnProxyOrigin is false
     expect(() => {
-      setCookie(win, 'c&1', 'v&1', Date.now() + BASE_CID_MAX_AGE_MILLIS, {});
+      allowConsoleError(() => {
+        setCookie(win, 'c&1', 'v&1', Date.now() + BASE_CID_MAX_AGE_MILLIS, {});
+      });
     }).to.throw(/Should never attempt to set cookie on proxy origin\: c\&1/);
 
     win.location = 'https://CDN.ampproject.org/test.html';
     expect(() => {
-      setCookie(win, 'c&1', 'v&1', Date.now() + BASE_CID_MAX_AGE_MILLIS, {});
+      allowConsoleError(() => {
+        setCookie(win, 'c&1', 'v&1', Date.now() + BASE_CID_MAX_AGE_MILLIS, {});
+      });
     }).to.throw(/Should never attempt to set cookie on proxy origin\: c\&1/);
 
     win.location = 'https://foo.bar.cdn.ampproject.org/test.html';
     expect(() => {
-      setCookie(win, 'c&1', 'v&1', Date.now() + BASE_CID_MAX_AGE_MILLIS, {});
+      allowConsoleError(() => {
+        setCookie(win, 'c&1', 'v&1', Date.now() + BASE_CID_MAX_AGE_MILLIS, {});
+      });
     }).to.throw(/in depth check/);
 
     win.location = 'http://&&&.CDN.ampproject.org/test.html';
     expect(() => {
-      setCookie(win, 'c&1', 'v&1', Date.now() + BASE_CID_MAX_AGE_MILLIS, {});
+      allowConsoleError(() => {
+        setCookie(win, 'c&1', 'v&1', Date.now() + BASE_CID_MAX_AGE_MILLIS, {});
+      });
     }).to.throw(/in depth check/);
 
     // Can't use higestAvailableDomain when allowOnProxyOrigin
     expect(() => {
-      setCookie(win, 'c&1', 'v&1', Date.now() + BASE_CID_MAX_AGE_MILLIS, {
-        allowOnProxyOrigin: true,
-        highestAvailableDomain: true,
+      allowConsoleError(() => {
+        setCookie(win, 'c&1', 'v&1', Date.now() + BASE_CID_MAX_AGE_MILLIS, {
+          allowOnProxyOrigin: true,
+          highestAvailableDomain: true,
+        });
       });
     }).to.throw(/specify domain explicitly/);