Skip to content

Commit

Permalink
Reverse behavior of responsive auto ads experiment to ramp up to 95%
Browse files Browse the repository at this point in the history
  • Loading branch information
Noran Azmy committed Mar 25, 2019
1 parent a43db2f commit d4e3b0f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion extensions/amp-auto-ads/0.1/ad-network-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ class AdSenseNetworkConfig {
*/
isResponsiveEnabled(win) {
const branch = getAdSenseAmpAutoAdsResponsiveExperimentBranch(win);
return branch != AdSenseAmpAutoAdsResponsiveBranches.CONTROL;
return branch == AdSenseAmpAutoAdsResponsiveBranches.CONTROL;
}

/** @override */
Expand Down
8 changes: 4 additions & 4 deletions extensions/amp-auto-ads/0.1/test/test-ad-network-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,19 +71,19 @@ describes.realWin('ad-network-config', {
});

it('should report responsive-enabled when responsive experiment on and ' +
'experiment branch picked', () => {
'control branch picked', () => {
forceExperimentBranch(env.win,
ADSENSE_AMP_AUTO_ADS_RESPONSIVE_EXPERIMENT_NAME,
AdSenseAmpAutoAdsResponsiveBranches.EXPERIMENT);
AdSenseAmpAutoAdsResponsiveBranches.CONTROL);
const adNetwork = getAdNetworkConfig('adsense', ampAutoAdsElem);
expect(adNetwork.isResponsiveEnabled(env.win)).to.equal(true);
});

it('should report responsive-disabled when responsive experiment on ' +
'and control branch picked', () => {
'and experiment branch picked', () => {
forceExperimentBranch(env.win,
ADSENSE_AMP_AUTO_ADS_RESPONSIVE_EXPERIMENT_NAME,
AdSenseAmpAutoAdsResponsiveBranches.CONTROL);
AdSenseAmpAutoAdsResponsiveBranches.EXPERIMENT);
const adNetwork = getAdNetworkConfig('adsense', ampAutoAdsElem);
expect(adNetwork.isResponsiveEnabled(env.win)).to.equal(false);
});
Expand Down

0 comments on commit d4e3b0f

Please sign in to comment.