remove styles npm/cdn bento packages (#36873)

ampproject · Nov 10, 2021 · de4f57c · de4f57c
1 parent 081a0b7
commit de4f57c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 21 deletions.
diff --git a/build-system/tasks/extension-helpers.js b/build-system/tasks/extension-helpers.js
@@ -755,11 +755,7 @@ async function getBentoBuildFilename(dir, name, mode, options) {
   if (await fs.pathExists(`${dir}/${filename}`)) {
     return filename;
   }
-  const generatedSource = await generateBentoEntryPointSource(
-    name,
-    toExport,
-    options
-  );
+  const generatedSource = await generateBentoEntryPointSource(name, toExport);
   const generatedFilename = `build/${filename}`;
   await fs.outputFile(`${dir}/${generatedFilename}`, generatedSource);
   return generatedFilename;
@@ -768,34 +764,21 @@ async function getBentoBuildFilename(dir, name, mode, options) {
 /**
  * @param {string} name
  * @param {string} toExport
- * @param {Object} options
  * @return {Promise<string>}
  */
-async function generateBentoEntryPointSource(name, toExport, options) {
-  const css = options.hasCss
-    ? await fs.readFile(`build/css/${name}-${options.version}.css`, 'utf8')
-    : null;
-
+async function generateBentoEntryPointSource(name, toExport) {
   return dedent(`
     import {BaseElement} from '../base-element';
-    
+
     function defineElement() {
-      const css = __css__;
-      if (css) {
-        const style = document.createElement('style');
-        style.textContent = css;
-        document.head.appendChild(style);
-      }
       customElements.define(
         __name__,
         BaseElement.CustomElement(BaseElement)
       );
     }
 
     ${toExport ? 'export {defineElement};' : 'defineElement();'}
-  `)
-    .replace('__css__', JSON.stringify(css))
-    .replace('__name__', JSON.stringify(name));
+  `).replace('__name__', JSON.stringify(name));
 }
 
 /**

diff --git a/test/fixtures/e2e/bento/social-share.html b/test/fixtures/e2e/bento/social-share.html
@@ -13,6 +13,7 @@
       async
       src="https://cdn.ampproject.org/v0/bento-social-share-1.0.js"
     ></script>
+    <link rel="stylesheet" href="https://cdn.ampproject.org/v0/bento-social-share-1.0.css">
   </head>
   <body>
     <h1>Social Share</h1>

diff --git a/test/fixtures/e2e/bento/timeago.html b/test/fixtures/e2e/bento/timeago.html
@@ -12,6 +12,7 @@
       async
       src="https://cdn.ampproject.org/v0/bento-timeago-1.0.js"
     ></script>
+    <link rel="stylesheet" href="https://cdn.ampproject.org/v0/bento-timeago-1.0.css">
   </head>
   <body>
     <h1>Time Ago</h1>