Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bento: Prepare Twitter Preact implementation (#34194)
* Do not override user given height until message gives one * Support tweetid directly * Support bootstrap directly * Add unit tests * Support momentid directly * Add Storybook samples for additional options * Use Sinon syntax for spying on setter
- Loading branch information
Showing
4 changed files
with
228 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| /** | ||
| * Copyright 2020 The AMP HTML Authors. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS-IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import * as Preact from '../../../../src/preact'; | ||
| import {Twitter} from '../component'; | ||
| import {WithAmpContext} from '../../../../src/preact/context'; | ||
| import {createRef} from '../../../../src/preact'; | ||
| import {mount} from 'enzyme'; | ||
| import {serializeMessage} from '../../../../src/3p-frame-messaging'; | ||
| import {waitFor} from '../../../../testing/test-helper'; | ||
|
|
||
| describes.sandboxed('Twitter preact component v1.0', {}, (env) => { | ||
| it('should render', () => { | ||
| const wrapper = mount( | ||
| tweetid="1356304203044499462" | ||
| style={{ | ||
| 'width': '500px', | ||
| 'height': '600px', | ||
| }} | ||
| /> | ||
| ); | ||
|
|
||
| const iframe = wrapper.find('iframe'); | ||
|
|
||
| expect(iframe.prop('src')).to.equal( | ||
| 'http://ads.localhost:9876/dist.3p/current/frame.max.html' | ||
| ); | ||
| expect(wrapper.find('iframe').prop('style').width).to.equal('100%'); | ||
| expect(wrapper.find('iframe').prop('style').height).to.equal('100%'); | ||
| }); | ||
|
|
||
| it('should call given requestResize', () => { | ||
| const requestResizeSpy = env.sandbox.spy(); | ||
| const wrapper = mount( | ||
| tweetid="1356304203044499462" | ||
| style={{ | ||
| 'width': '500px', | ||
| 'height': '600px', | ||
| }} | ||
| requestResize={requestResizeSpy} | ||
| /> | ||
| ); | ||
|
|
||
| const iframe = wrapper.find('iframe').getDOMNode(); | ||
| const sentinel = JSON.parse(iframe.getAttribute('name'))['attributes'][ | ||
| 'sentinel' | ||
| ]; | ||
|
|
||
| const mockEvent = new CustomEvent('message'); | ||
| mockEvent.data = serializeMessage('embed-size', sentinel, { | ||
| 'height': 1000, | ||
| }); | ||
| mockEvent.source = wrapper | ||
| .getDOMNode() | ||
| .querySelector('iframe').contentWindow; | ||
| window.dispatchEvent(mockEvent); | ||
|
|
||
| expect(requestResizeSpy).to.have.been.calledOnce; | ||
| }); | ||
|
|
||
| it('should change height', async () => { | ||
| const wrapper = mount( | ||
| tweetid="1356304203044499462" | ||
| style={{ | ||
| 'width': '500px', | ||
| 'height': '600px', | ||
| }} | ||
| /> | ||
| ); | ||
|
|
||
| const iframe = wrapper.find('iframe').getDOMNode(); | ||
| const sentinel = JSON.parse(iframe.getAttribute('name'))['attributes'][ | ||
| 'sentinel' | ||
| ]; | ||
|
|
||
| const mockEvent = new CustomEvent('message'); | ||
| mockEvent.data = serializeMessage('embed-size', sentinel, { | ||
| 'height': 1000, | ||
| }); | ||
| mockEvent.source = wrapper | ||
| .getDOMNode() | ||
| .querySelector('iframe').contentWindow; | ||
| window.dispatchEvent(mockEvent); | ||
|
|
||
| wrapper.update(); | ||
|
|
||
| await waitFor( | ||
| () => wrapper.find('div').at(0).prop('style').height == 1000, | ||
| 'Height changes' | ||
| ); | ||
|
|
||
| expect(wrapper.find('div').at(0).prop('style').height).to.equal(1000); | ||
| }); | ||
|
|
||
| it('should dispatch load event', async () => { | ||
| const ref = createRef(); | ||
| const onReadyState = env.sandbox.spy(); | ||
| const wrapper = mount( | ||
| ref={ref} | ||
| tweetid="1356304203044499462" | ||
| style={{ | ||
| 'width': '500px', | ||
| 'height': '600px', | ||
| }} | ||
| onReadyState={onReadyState} | ||
| /> | ||
| ); | ||
|
|
||
| let api = ref.current; | ||
| expect(api.readyState).to.equal('loading'); | ||
| expect(onReadyState).to.not.be.called; | ||
|
|
||
| await wrapper.find('iframe').invoke('onLoad')(); | ||
| api = ref.current; | ||
| expect(api.readyState).to.equal('complete'); | ||
| expect(onReadyState).to.be.calledOnce.calledWith('complete'); | ||
| }); | ||
|
|
||
| it('should reset iframe on pause', () => { | ||
| const ref = createRef(); | ||
| const wrapper = mount( | ||
| <WithAmpContext playable={true}> | ||
| ref={ref} | ||
| tweetid="1356304203044499462" | ||
| style={{ | ||
| 'width': '500px', | ||
| 'height': '600px', | ||
| }} | ||
| /> | ||
| </WithAmpContext> | ||
| ); | ||
| expect(wrapper.find('iframe')).to.have.lengthOf(1); | ||
|
|
||
| const iframe = wrapper.find('iframe').getDOMNode(); | ||
| const spy = env.sandbox.spy(iframe, 'src', ['set']); | ||
| wrapper.setProps({playable: false}); | ||
| expect(spy.set).to.be.calledOnce; | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters