Skip to content

Commit

Permalink
unobserveIntersection: fix reset typo (#36310)
Browse files Browse the repository at this point in the history
  • Loading branch information
samouri committed Oct 11, 2021
1 parent 303ee1a commit e1acc2c
Show file tree
Hide file tree
Showing 12 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion extensions/amp-3d-gltf/0.1/amp-3d-gltf.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export class Amp3dGltf extends AMP.BaseElement {
/** @override */
unlayoutCallback() {
this.unobserveIntersections_?.();
this.unobserveIntersections = null;
this.unobserveIntersections_ = null;
this.viewportCallback_(false);
if (this.iframe_) {
removeElement(this.iframe_);
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-a4a/0.1/amp-a4a.js
Original file line number Diff line number Diff line change
Expand Up @@ -1420,7 +1420,7 @@ export class AmpA4A extends AMP.BaseElement {
/** @override */
unlayoutCallback() {
this.unobserveIntersections_?.();
this.unobserveIntersections = null;
this.unobserveIntersections_ = null;
this.tearDownSlot();
return true;
}
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-ad/0.1/amp-ad-3p-impl.js
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ export class AmpAd3PImpl extends AMP.BaseElement {
this.unlisteners_.forEach((unlisten) => unlisten());
this.unlisteners_.length = 0;
this.unobserveIntersections_?.();
this.unobserveIntersections = null;
this.unobserveIntersections_ = null;

this.layoutPromise_ = null;
this.uiHandler.applyUnlayoutUI();
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-anim/0.1/amp-anim.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export class AmpAnim extends AMP.BaseElement {
/** @override */
unlayoutCallback() {
this.unobserveIntersections_?.();
this.unobserveIntersections = null;
this.unobserveIntersections_ = null;
this.viewportCallback_(false);
// Release memory held by the image - animations are typically large.
this.img_.src = SRC_PLACEHOLDER;
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-apester-media/0.1/amp-apester-media.js
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ class AmpApesterMedia extends AMP.BaseElement {
/** @override */
unlayoutCallback() {
this.unobserveIntersections_?.();
this.unobserveIntersections = null;
this.unobserveIntersections_ = null;
if (this.iframe_) {
this.intersectionObserverHostApi_.destroy();
this.intersectionObserverHostApi_ = null;
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-carousel/0.1/base-carousel.js
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ export class BaseCarousel extends AMP.BaseElement {
/** @override */
unlayoutCallback() {
this.unobserveIntersections_?.();
this.unobserveIntersections = null;
this.unobserveIntersections_ = null;
return true;
}

Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-carousel/0.1/scrollable-carousel.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export class AmpScrollableCarousel extends BaseCarousel {
/** @override */
unlayoutCallback() {
this.unobserveIntersections_?.();
this.unobserveIntersections = null;
this.unobserveIntersections_ = null;
return super.unlayoutCallback();
}

Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-carousel/0.1/slidescroll.js
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ export class AmpSlideScroll extends BaseCarousel {
/** @override */
unlayoutCallback() {
this.unobserveIntersections_?.();
this.unobserveIntersections = null;
this.unobserveIntersections_ = null;
this.slideIndex_ = null;
return super.unlayoutCallback();
}
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-delight-player/0.1/amp-delight-player.js
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ class AmpDelightPlayer extends AMP.BaseElement {

this.unregisterEventHandlers_();
this.unobserveIntersections_?.();
this.unobserveIntersections = null;
this.unobserveIntersections_ = null;
this.pauseHelper_.updatePlaying(false);

return true;
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-image-slider/0.1/amp-image-slider.js
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,7 @@ export class AmpImageSlider extends AMP.BaseElement {
/** @override */
unlayoutCallback() {
this.unobserveIntersections_?.();
this.unobserveIntersections = null;
this.unobserveIntersections_ = null;
this.unregisterEvents_();
return true;
}
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-playbuzz/0.1/amp-playbuzz.js
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ class AmpPlaybuzz extends AMP.BaseElement {
/** @override */
unlayoutCallback() {
this.unobserveIntersections_?.();
this.unobserveIntersections = null;
this.unobserveIntersections_ = null;
this.unlisteners_.forEach((unlisten) => unlisten());
this.unlisteners_.length = 0;

Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-timeago/0.1/amp-timeago.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export class AmpTimeAgo extends AMP.BaseElement {
/** @override */
unlayoutCallback() {
this.unobserveIntersections_?.();
this.unobserveIntersections = null;
this.unobserveIntersections_ = null;
return false;
}

Expand Down

0 comments on commit e1acc2c

Please sign in to comment.