watch src dir for v0.js (#32835)

* watch src dir for v0.js * lint * Update lazy server, propagate a watch:false * Update build-system/server/lazy-build.js Co-authored-by: Raghu Simha <rsimha@amp.dev> * lint fixes, and racey fix Co-authored-by: Raghu Simha <rsimha@amp.dev>
ampproject · Feb 24, 2021 · e1bfc81 · e1bfc81
1 parent 8d7197e
commit e1bfc81
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/build-system/server/lazy-build.js b/build-system/server/lazy-build.js
@@ -21,7 +21,7 @@ const {
   maybeInitializeExtensions,
   getExtensionsToBuild,
 } = require('../tasks/extension-helpers');
-const {doBuildJs} = require('../tasks/helpers');
+const {doBuildJs, compileCoreRuntime} = require('../tasks/helpers');
 const {jsBundles} = require('../compile/bundles.config');
 
 const extensionBundles = {};
@@ -131,7 +131,9 @@ async function lazyBuildJs(req, _res, next) {
  * Pre-builds the core runtime and the JS files that it loads.
  */
 async function preBuildRuntimeFiles() {
-  await build(jsBundles, 'amp.js', doBuildJs);
+  await build(jsBundles, 'amp.js', (_bundles, _name, options) =>
+    compileCoreRuntime(options)
+  );
   await build(jsBundles, 'ww.max.js', doBuildJs);
 }
 

diff --git a/build-system/tasks/helpers.js b/build-system/tasks/helpers.js
@@ -150,7 +150,22 @@ async function bootstrapThirdPartyFrames(options) {
  * @param {!Object} options
  */
 async function compileCoreRuntime(options) {
-  await doBuildJs(jsBundles, 'amp.js', options);
+  async function watchFunc() {
+    const bundleComplete = await doBuildJs(jsBundles, 'amp.js', {
+      ...options,
+      watch: false,
+    });
+    if (options.onWatchBuild) {
+      options.onWatchBuild(bundleComplete);
+    }
+  }
+
+  if (options.watch) {
+    const debouncedRebuild = debounce(watchFunc, watchDebounceDelay);
+    fileWatch('src/**/*.js').on('change', debouncedRebuild);
+  }
+
+  await doBuildJs(jsBundles, 'amp.js', {...options, watch: false});
 }
 
 /**