Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable amp-bind integration tests on Saucelabs #10053

Closed
jridgewell opened this issue Jun 20, 2017 · 5 comments
Closed

Re-enable amp-bind integration tests on Saucelabs #10053

jridgewell opened this issue Jun 20, 2017 · 5 comments

Comments

@jridgewell
Copy link
Contributor

Chrome 45.0.2454 (Windows 7 0.0.0) amp-bind with <amp-state> "before each" hook for "should not loop infinitely if updates change its src binding" FAILED
	Error: timeout of 10000ms exceeded. Ensure the done() callback is being called in this test.
..............................
Edge 15.15063.0 (Windows 10 0.0.0) amp-bind with <amp-list> "before each" hook for "should NOT change src when new value uses an invalid protocol" FAILED
	Error: timeout of 10000ms exceeded. Ensure the done() callback is being called in this test.
............................
Chrome 59.0.3071 (Windows 7 0.0.0) amp-bind with <amp-video> "before each" hook for "should change alt when the alt attribute binding changes" FAILED
	Error: timeout of 10000ms exceeded. Ensure the done() callback is being called in this test.
............................
Safari 9.1.2 (Mac OS X 10.11.6) amp-bind with <amp-iframe> "before each" hook for "should support binding to src" FAILED
	timeout of 10000ms exceeded. Ensure the done() callback is being called in this test.
Safari 9.1.2 (Mac OS X 10.11.6) amp-bind with <amp-list> "before each" hook for "should support binding to src" FAILED
	timeout of 10000ms exceeded. Ensure the done() callback is being called in this test.
@rsimha
Copy link
Contributor

rsimha commented Jun 22, 2017

Still flaky: https://travis-ci.org/ampproject/amphtml/builds/245881991

Edit: Unless the source of the failing tests lies elsewhere? @jridgewell?

@rsimha rsimha reopened this Jun 22, 2017
@dreamofabear dreamofabear added this to the Sprint H2 June milestone Jun 22, 2017
@dreamofabear
Copy link

dreamofabear commented Jun 22, 2017

I think amp-bind tests don't run on Saucelabs with Justin's change. These are the errors in the build above (hard to read w/o colors):

Safari 9.1.2 (Mac OS X 10.11.6) error page "before each" hook for "should show the body in error test" FAILED
Timeout waiting for elements to start loading.

Safari 9.1.2 (Mac OS X 10.11.6) test extensions loading in multiple orders one extension, extension loads first, all scripts in header FAILED
Timeout waiting for elements to start loading.

#9906

Chrome Mobile 44.0.2403 (Android 6.0.0) amp-pixel amp-pixel integration test "before each" hook for "should keep referrer if no referrerpolicy specified" FAILED
Error: timeout of 10000ms exceeded. Ensure the done() callback is being called in this test.

#9908

@dreamofabear
Copy link

Changing this issue to track re-enabling of amp-bind integration tests on Saucelabs.

@dreamofabear dreamofabear changed the title amp-bind integration failures Re-enable amp-bind integration tests on Saucelabs Jun 26, 2017
@dreamofabear
Copy link

Browser-specific flakiness in <amp-form> integration test:

  • This only affects Edge and Safari 9, but is fine on Chrome, Firefox and Safari 10.
  • Not caused by a race with AmpFormService registration.
  • Might have to do with expected user errors.

@dreamofabear
Copy link

These tests are running on SL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Runtime
Fixit
Development

No branches or pull requests

4 participants