Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-bind: <amp-form> integration test broken on Edge & Safari 9 #9759

Closed
camelburrito opened this issue Jun 7, 2017 · 3 comments
Closed

Comments

@camelburrito
Copy link
Contributor

Here is the travis build
https://travis-ci.org/ampproject/amphtml/jobs/240195458

Edge 14.14393.0 (Windows 10 0.0.0) amp-bind with <amp-form> should NOT allow invalid bindings or values FAILED
	Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.
................................
Safari 9.1.2 (Mac OS X 10.11.6) amp-bind with <amp-form> should NOT allow invalid bindings or values FAILED
	timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.

.......
Mobile Safari 9.0.0 (iOS 9.1.0) amp-bind with <amp-form> should NOT allow invalid bindings or values FAILED
	timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.


@camelburrito
Copy link
Contributor Author

@choumx @cvializ - These tests are blocking the canary , please take a look and skip them if you think its ok to skip or submit fixes/revert them. I would like to make the master green and cut the canary

@dreamofabear
Copy link

dreamofabear commented Jun 7, 2017

Reducing priority since master is green now.

@dreamofabear dreamofabear added this to the Fixit Week EOQ2 milestone Jun 7, 2017
@dreamofabear dreamofabear changed the title Flaky/Broken amp-bind + form integration tests amp-bind: <amp-form> integration test broken on Edge & Safari 9 Jun 7, 2017
@dreamofabear
Copy link

Merging with #10053.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants