Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow amp-animation in the AMP ad spec #10093

Closed
jasti opened this issue Jun 22, 2017 · 2 comments · Fixed by #10213
Closed

Allow amp-animation in the AMP ad spec #10093

jasti opened this issue Jun 22, 2017 · 2 comments · Fixed by #10213
Assignees
@Gregable @honeybadgerdontcare
Labels
WG: caching WG: monetization
Projects
AMP Advertising
Milestone
Prioritized FRs

Comments

@jasti
Copy link
Contributor

jasti commented Jun 22, 2017

amp-animation is allowed to be used in an AMP page but doesn't validate when used as an ad. Can we please whitelist it and update markdown when in prod?

CC @Gregable @ampproject/a4a
@jasti jasti added this to the Prioritized FRs milestone Jun 22, 2017
@jasti jasti changed the title Allow amp-animation in the A4A Spec Allow amp-animation in the AMP ad spec Jun 22, 2017
@honeybadgerdontcare
Copy link
Contributor

@Gregable fyi we usually remove html_format for cases where it is intended for both formats. if you don't get to it by end of next week I'll look into it.

@Gregable Gregable mentioned this issue Jun 30, 2017
Merged
Gregable added a commit that referenced this issue Jun 30, 2017
@Gregable
Allow <amp-animation> on AMP4ADS documents. (#10213)
6b24ad2 
* Allow `<amp-animation>` on AMP4ADS documents.

Resolves #10093
@Gregable
Copy link
Member

This is fixed. I'll update the issue when it's released.

@lannka lannka added this to Done in AMP Advertising Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gregable Gregable

@honeybadgerdontcare honeybadgerdontcare

Labels
WG: caching WG: monetization
Projects
AMP Advertising
  
Done
Milestone
Prioritized FRs
Development

Successfully merging a pull request may close this issue.

Allow <amp-animation> on AMP4ADS documents.
3 participants
@Gregable @honeybadgerdontcare @jasti