Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the new scrollTo action to also optionally focus #10670

Closed
aghassemi opened this issue Jul 27, 2017 · 1 comment
Closed

Allow the new scrollTo action to also optionally focus #10670

aghassemi opened this issue Jul 27, 2017 · 1 comment
Assignees
@aghassemi

Comments

@aghassemi
Copy link
Contributor

After #10398 , we now have both scrollTo and focus as actions. One use-case we are missing to smooth scrolling to a target and then focusing on it. Chaning scrollTo and focus won't work since actions don't wait for each other to finish so we endup with browser undoing the scrollTo's smoothness when focus is called.
@aghassemi aghassemi self-assigned this Jul 27, 2017
@aghassemi
Copy link
Contributor Author

actually after testing, this works fine, neither Chrome or Safari undo the current scrolling when focus is called. I will just add a sample for it.

@aghassemi aghassemi mentioned this issue Jul 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aghassemi aghassemi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aghassemi