Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scrollTo and focus example #10672

Merged
merged 1 commit into from Jul 27, 2017
Merged

Add scrollTo and focus example #10672

merged 1 commit into from Jul 27, 2017

Conversation

aghassemi
Copy link
Contributor

Closes #10670

@aghassemi aghassemi requested a review from wassgha July 27, 2017 16:26
@wassgha
Copy link
Contributor

wassgha commented Jul 27, 2017

Have you tried this behavior on the same element? Would it sill scroll first then focus?

wassgha
wassgha approved these changes Jul 27, 2017
View reviewed changes
Copy link
Contributor

@wassgha wassgha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aghassemi
Copy link
Contributor Author

@wassgha yeah works fine for same element too. It focuses immediately, but browser is smart enough not to fast scroll to it since another scrolling had already started.

@aghassemi aghassemi merged commit baa93ee into ampproject:master Jul 27, 2017
@aghassemi aghassemi mentioned this pull request Jul 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wassgha wassgha wassgha approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aghassemi @wassgha @googlebot @ampprojectbot