You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Create a PR and wait for it to be tested on Travis (the percy/amphtml check will fail)
Click the details link and approve the Percy build that was generated on your PR branch
Merge your PR and approve the next Percy build on master. Until you do so, master will be red, and this is expected.
Tip: Use #11413 as an example of how to add a new visual test. If your test page needs time to reach a steady state before a snapshot is taken, you can specify css classes that need to be visible, eventually appear, or eventually disappear. See test/visual-diff/visual-tests.json for examples.
Documentation: See this page on the AMP developer guide.
The following components owned by @aghassemi do not have visual diff test coverage.
How to add a visual test:
examples/
, or create a new one based on AMP by Example.percy/amphtml
check will fail)details
link and approve the Percy build that was generated on your PR branchmaster
will be red, and this is expected.Tip: Use #11413 as an example of how to add a new visual test. If your test page needs time to reach a steady state before a snapshot is taken, you can specify css classes that need to be visible, eventually appear, or eventually disappear. See test/visual-diff/visual-tests.json for examples.
Documentation: See this page on the AMP developer guide.
Master issue: #10155
The text was updated successfully, but these errors were encountered: