Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a screen that indicates that the user's browser is unsupported by amp-story #11853

Closed
newmuis opened this issue Oct 30, 2017 · 4 comments
Closed

Add a screen that indicates that the user's browser is unsupported by amp-story #11853

newmuis opened this issue Oct 30, 2017 · 4 comments
Assignees
@newmuis
Labels
P2: Soon WG: stories
Projects
Stories - By Type
Milestone
Active Non-Sprint...

Comments

@newmuis
Copy link
Contributor

newmuis commented Oct 30, 2017

amp-story does not yet support all browsers that AMP generally supports. Until we achieve parity, we should add a screen that tells a user if they are using an unsupported browser by checking the features we need with @supports or CSS.supports or the appropriate checks for whichever JavaScript functionality we depend on.

Mocks TBD
@dreamofabear
Copy link

Which browsers are not supported and which features are they lacking? We should publicly document this in amp-story.md.

@newmuis newmuis changed the title Add a screen that Add a screen that indicates that the user's browser is unsupported Oct 30, 2017
@newmuis
Copy link
Contributor Author

newmuis commented Oct 30, 2017 •
edited

We don't have this list, but amp-story does use some fairly cutting edge features:

@newmuis newmuis changed the title Add a screen that indicates that the user's browser is unsupported Add a screen that indicates that the user's browser is unsupported by amp-story Oct 30, 2017
@ampprojectbot ampprojectbot added this to the Pending Triage milestone Oct 30, 2017
@dvoytenko
Copy link
Contributor

@newmuis @choumx would you mind assigning this issue a milestone?

@dreamofabear dreamofabear added this to Fixit in Stories - By Type Nov 3, 2017
@newmuis newmuis moved this from Fixit to Developer Preview Blocking in Stories - By Type Nov 22, 2017
@newmuis newmuis moved this from Developer Preview Blocking to Post-Developer Preview in Stories - By Type Jan 9, 2018
@newmuis
Copy link
Contributor Author

newmuis commented Jan 18, 2018 •
edited

Currently, our supported browser list looks like:

  • Android Chrome: 57+
  • Android Stock Browser: 62+
  • Android Samsung Browser: 6.2+
  • Android UC Browser: 12.0+
  • iOS Safari: 10.3+
  • iOS Chrome: 57+

@newmuis newmuis mentioned this issue Jan 30, 2018
Merged
Stories - By Type automation moved this from Post-Developer Preview to Done Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@newmuis newmuis

Labels
P2: Soon WG: stories
Projects
Stories - By Type
  
Done
Milestone
Active Non-Sprint Tracked
Development

No branches or pull requests
4 participants
@dvoytenko @newmuis @dreamofabear @ampprojectbot