Add a screen that tells users that their browser is unsupported #13137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmajoulet
reviewed
Jan 30, 2018
| /** | ||
| * Build overlay for Landscape mode mobile | ||
| */ | ||
| buildUnsupportedBrowserOverlay_() { |
There was a problem hiding this comment.
Should we also detach the amp-story-page components from the DOM to make sure there's no sound / video playing?
Also, not very important since we're not playing the story, but as a good practice I think we should always interact with the DOM from vsync tasks.
There was a problem hiding this comment.
Done, for vsync.
Removing the elements from the DOM causes all kinds of errors since there are a number of race conditions introduced by doing that. Every AMP element manages its own lifecycle, so the other elements get messed up by being removed from the DOM when they weren't expecting it.
|
Added an expected error to track when users hit this case. |
|
LGTM |
prateekbh
approved these changes
Jan 30, 2018
gmajoulet
approved these changes
Jan 30, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
…roject#13137) * Add unsupported browser screen. * Remove testing condition. * Add expected error and prevent layoutCallback * Fix line length * Assume browser is supported during tests. * Remove testing condition.
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
…roject#13137) * Add unsupported browser screen. * Remove testing condition. * Add expected error and prevent layoutCallback * Fix line length * Assume browser is supported during tests. * Remove testing condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11853