Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-carousel doesn't display text after images #1318

Closed
davidreghay opened this issue Jan 6, 2016 · 4 comments
Closed

amp-carousel doesn't display text after images #1318

davidreghay opened this issue Jan 6, 2016 · 4 comments
Assignees
Milestone

Comments

@davidreghay
Copy link

If you place inside an amp-carousel a series of div containers with amp-imgs inside of them and text following the images, images display in the carousel but the text does not. Inspecting the document shows that the text is still in the DOM and I cannot find any CSS rules that would hide the text but it is clearly absent from the actual view in the browser.

@dvoytenko
Copy link
Contributor

@davidreghay do you think you could include a sample for us to troubleshoot?

@davidreghay
Copy link
Author

Sorry, I missed your response until now! The specific sample is proprietary code (on an employer's server) but within the next few days I will attempt to reproduce independently. If successful I'll include a sample here. Thank you!

@rudygalfi rudygalfi added this to the M1 milestone Feb 4, 2016
@rudygalfi rudygalfi modified the milestones: Feb 13, M1 Feb 4, 2016
@dvoytenko
Copy link
Contributor

@davidreghay Here are couple of ideas how to combine images and text in the carousel:

http://jsbin.com/mucifob/edit?html,css,output

I'll close this bug for now, but please reopen if you have any issues.

@davidreghay
Copy link
Author

@dvoytenko Thanks this looks really great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants