Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbox performance review #13321

Closed
cathyxz opened this issue Feb 6, 2018 · 2 comments
Closed

Lightbox performance review #13321

cathyxz opened this issue Feb 6, 2018 · 2 comments

Comments

@cathyxz
Copy link
Contributor

cathyxz commented Feb 6, 2018

  1. Go through Chrome devtools performance profiling to identify bottlenecks.
  2. Go through all measurements and mutations and make sure that they only happen within vsync blocks.
  3. Review the component design to see if there are other performance optimizations that we can do.
@cathyxz
Copy link
Contributor Author

cathyxz commented Feb 26, 2018

Results of perf profiling on Chrome Devtools

Here's a rough list of perf bottlenecks on open lightbox:

  • getBoundingClientRect
  • animation add
  • Gestures
  • updateDescriptionBox (the use of innerText)?

on change slide:

  • shouldTriggerClick
  • updateImageSrc

@cathyxz
Copy link
Contributor Author

cathyxz commented Mar 22, 2018

We did a couple of passes on this via #13809, #14141, and #13679. Performance on low-end phones is now decent after #14119, with the caveat of needing to not use 5MB+ images.

@cathyxz cathyxz closed this as completed Mar 22, 2018
@cathyxz cathyxz added this to Done in UI Triage via automation Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
UI Triage
  
Done
Development

No branches or pull requests

2 participants