First pass on optimizing lightbox performance #13679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvializ
reviewed
Feb 27, 2018
| this.toggleDescriptionOverflow_(); | ||
| event.stopPropagation(); | ||
| }); | ||
| this.container_.appendChild(this.descriptionBox_); |
There was a problem hiding this comment.
I think the only part that needs to be inside the vsync.mutate block is this.container_.appendChild(this.descriptionBox_); since that's the only mutation to the live DOM tree. Everything else is mutating detached nodes and has no effect on layout. The same goes for the other build* methods that create and modify new detached DOM nodes.
There was a problem hiding this comment.
Oh got it. Thank you!
aghassemi
approved these changes
Feb 27, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* Improve lightbox performance * Don't need to vsync mutate detached node manipulations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some mutations that didn't go in
vsync.mutate.