Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Awesome validation regex need to be updated. #13770

Closed
jpettitt opened this issue Mar 2, 2018 · 1 comment · Fixed by #13773
Closed

Font Awesome validation regex need to be updated. #13770

jpettitt opened this issue Mar 2, 2018 · 1 comment · Fixed by #13773
Assignees
@jpettitt

Comments

@jpettitt
Copy link
Contributor

jpettitt commented Mar 2, 2018 •
edited

FA have introduced a new font domain and url structure that is failing validation

Old format

https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css

new format

https://use.fontawesome.com/releases/v5.0.7/css/all.css

@Gregable
@jpettitt
Copy link
Contributor Author

jpettitt commented Mar 2, 2018

Never mind, dupe of #13685

jpettitt added a commit to jpettitt/amphtml that referenced this issue Mar 2, 2018
@jpettitt
Add new Font Awseome URL format fixes ampproject#13770 and ampproject…
55b3480 
…#13685
@jpettitt jpettitt mentioned this issue Mar 2, 2018
Merged
honeybadgerdontcare pushed a commit that referenced this issue Mar 2, 2018
@jpettitt @honeybadgerdontcare
🐛 Add new Font Awseome URL format, fixes #13770 and #13685 (#13773)
af1e3a5
@honeybadgerdontcare honeybadgerdontcare mentioned this issue Mar 2, 2018
Merged
RanAbram pushed a commit to RanAbram/amphtml that referenced this issue Mar 12, 2018
@jpettitt @RanAbram
🐛 Add new Font Awseome URL format, fixes ampproject#13770 and ampproj…
13bb323 
…ect#13685 (ampproject#13773)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpettitt jpettitt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Add new Font Awseome URL format, fixes #13770 and #13685 jpettitt/amphtml
1 participant
@jpettitt