Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-embed failed to build #13856

Closed
lannka opened this issue Mar 7, 2018 · 1 comment
Closed

amp-embed failed to build #13856

lannka opened this issue Mar 7, 2018 · 1 comment
Assignees
@lannka
Labels
P0: Drop Everything Type: Bug WG: monetization

Comments

@lannka
Copy link
Contributor

lannka commented Mar 7, 2018 

[Resource] failed to build: amp-embed#1 TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.
    at new AmpAdUIHandler (amp-ad-ui.js:36)
    at AmpAd3PImpl.buildCallback (amp-ad-3p-impl.js:169)

Suspicious PR: #13250

This is blocking release.

/cc @jridgewell
@lannka lannka self-assigned this Mar 7, 2018
@lannka lannka changed the title amp-ad failed to build amp-embed failed to build Mar 7, 2018
@lannka
Copy link
Contributor Author

lannka commented Mar 7, 2018

Root cause: addDefaultUiComponent_ returns null for amp-embed.

@lannka lannka mentioned this issue Mar 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lannka lannka

Labels
P0: Drop Everything Type: Bug WG: monetization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lannka