Mutate amp-ad inside mutation phase #13250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detected with [black magic](ampproject#13223).
lannka
approved these changes
Feb 5, 2018
jridgewell
force-pushed
the
amp-ad-mutate
branch
from
b997067
to
7c6e2b2
Compare
lannka
reviewed
Mar 7, 2018
| @@ -32,7 +32,8 @@ export class AmpAdUIHandler { | |||
| this.doc_ = baseInstance.win.document; | |||
|
|
|||
| if (!baseInstance.getFallback()) { | |||
| this.addDefaultUiComponent_('fallback'); | |||
| const fallback = this.addDefaultUiComponent_('fallback'); | |||
| this.baseInstance_.element.appendChild(fallback); | |||
There was a problem hiding this comment.
got an regression here:
[Resource] failed to build: amp-embed#1 TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.
at new AmpAdUIHandler (amp-ad-ui.js:36)
at AmpAd3PImpl.buildCallback (amp-ad-3p-impl.js:169)
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* Mutate amp-ad inside mutation phase Detected with [black magic](ampproject#13223). * Test updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detected with black magic.