Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-3d-gltf: problems with validator rules #15793

Closed
mixtur opened this issue Jun 4, 2018 · 3 comments
Closed

amp-3d-gltf: problems with validator rules #15793

mixtur opened this issue Jun 4, 2018 · 3 comments

Comments

@mixtur
Copy link
Contributor

mixtur commented Jun 4, 2018

What's the issue?

Validator complains

  • when alpha=true
  • on every camel-cased attribute

How do we reproduce the issue?

I tried to add sample for amp-by-example and stumbled upon this

this html claimed to be broken

<amp-3d-gltf layout="fixed"
             width="320"
             height="240"
             alpha="true"
             antialiasing="true"
             autoRotate="true"
             enableZoom="false"
             src="https://webgears-3d.github.io/3d-gltf-static/m/DamagedHelmet.glb"></amp-3d-gltf>

errors:

components/amp-3d-gltf/source/index.html:43:2 The attribute 'alpha' in tag 'amp-3d-gltf' is set to the invalid value 'true'. (see https://www.ampproject.org/docs/reference/components/amp-3d-gltf)
components/amp-3d-gltf/source/index.html:43:2 The attribute 'autorotate' may not appear in tag 'amp-3d-gltf'. (see https://www.ampproject.org/docs/reference/components/amp-3d-gltf)
components/amp-3d-gltf/source/index.html:43:2 The attribute 'enablezoom' may not appear in tag 'amp-3d-gltf'. (see https://www.ampproject.org/docs/reference/components/amp-3d-gltf)
@mixtur
Copy link
Contributor Author

mixtur commented Jun 4, 2018

For alpha I just wrote wrong rule.
Need help with other attributes.

@aghassemi
Copy link
Contributor

@honeybadgerdontcare, could you please help @mixtur fix https://github.com/ampproject/amphtml/blob/master/extensions/amp-3d-gltf/validator-amp-3d-gltf.protoascii ? I wonder if case-sensitivity has something to do with these failure.

Let's ensure the validator test is updated here: https://github.com/ampproject/amphtml/blob/master/extensions/amp-3d-gltf/0.1/test/validator-amp-3d-gltf.html as well.

@aghassemi aghassemi added this to the Pending Triage milestone Jun 4, 2018
honeybadgerdontcare pushed a commit that referenced this issue Jun 5, 2018
Partially addresses #15793
Fixes alpha attribute.
AmazonPublisherServices pushed a commit to AmazonPublisherServices/amphtml that referenced this issue Jun 5, 2018
Partially addresses ampproject#15793
Fixes alpha attribute.
@Gregable
Copy link
Member

Gregable commented Jun 5, 2018

I believe this can be closed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants