Type paths to missing files in swg.js

[dreamofabear]

New versions of Closure Compiler upgraded "module not found" from warnings to errors. For example:

amphtml/third_party/subscriptions-project/swg.js

Lines 2272 to 2278 in 6b112a7

	/**
	* @param {!../model/doc.Doc} doc
	*/
	constructor(doc) {
	/** @private @const {!../model/doc.Doc} */
	this.doc_ = doc;
	}

!../model/doc.Doc doesn't exist in the bundled SWG binary.

Unfortunately don't seem suppressible with @suppress {moduleLoad}, individually or at the @fileoverview level. The current workaround is to not fail the build on warnings in swg.js replace these types with * via regex (see #18589).

To fix this, we can either strip these bogus types, use externs, or bundle these missing classes.

Context: #18552

/to @jpettit /cc @dvoytenko @dparikh

[jpettit]

@jpettitt

[dvoytenko]

/cc @erwinmombay I believe our decision was to keep comments in 3p as is, but ignore them - i.e. consider these files as not closure at all.

[jpettitt]

@choumx @erwinmombay can we close this based the comment from @dvoytenko ?

[dreamofabear]

Discussed with Dima and we agreed that type annotations in swg.js should be ignored. This means either (1) swg.js starts stripping JSDoc in its output or (2) amphtml strips JSDoc from swg.js in a compile preprocess.

This issue should be left open to track the implementation of one of these two.

[dvoytenko]

Currently SwG strips out types on the way. I'm not super happy about it, but it works for now. I do anticipate problems with this in the future and I believe (2) is the better path forward. But for now we have (1).

I also filed this: google/closure-compiler#3125

[dreamofabear]

Closing as status quo is acceptable by both AMP and SWG.