SwG release 0.1.22.30 #18746
Merged
SwG release 0.1.22.30 #18746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| locked = true; | ||
| } | ||
| const locked = (accessibleForFree && | ||
| accessibleForFree.toLowerCase() == 'false') || false; |
There was a problem hiding this comment.
IIRC, the newer version of CC could not determine that this expression result was boolean. Recommend reverting and making this change upstream if it complains.
There was a problem hiding this comment.
Yep. Now it's fine.
| @@ -2270,10 +2327,10 @@ const TITLE_LANG_MAP = { | |||
| class ButtonApi { | |||
|
|
|||
| /** | |||
| * @param {*} doc | |||
| * @param {!../model/doc.Doc} doc | |||
There was a problem hiding this comment.
"Cannot find module" is an error in newer CC. I replaced these with * with a manual regex search/replace:
#18586 for details.
dparikh
approved these changes
Oct 15, 2018
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Oct 18, 2018
* SwG release 0.1.22.30 * replace module-based types with wildcard
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* SwG release 0.1.22.30 * replace module-based types with wildcard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/subscriptions-project/swg-js/releases/tag/0.1.22.30