Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP-CONSENT v2 UI support #18828

Closed
5 tasks done
zhouyx opened this issue Oct 19, 2018 · 7 comments
Closed
5 tasks done

AMP-CONSENT v2 UI support #18828

zhouyx opened this issue Oct 19, 2018 · 7 comments
Assignees

Comments

@zhouyx
Copy link
Contributor

zhouyx commented Oct 19, 2018

  • Support full-screen API to allow iframe to expand to the fullscreen
  • Apply modal when expand to fullscreen
  • Provide default placeholder before iframe is ready. (30px)
  • Allow pub to apply modal to block content with non full screen iframe
  • [Optional] Allow iframe to customize initial height.
@torch2424
Copy link
Contributor

torch2424 commented Nov 7, 2018

Placeholder loader: https://jsbin.com/yerevoz/1/edit?html,output

We should position this in the center of the footer thing. If later on we want CMPs to change this, we will have them create their own, and just replace this default.

@ampprojectbot ampprojectbot added this to the Pending Triage milestone Nov 8, 2018
@torch2424
Copy link
Contributor

Add a refactor PR, to make ui actions match the same type/action format.

@torch2424
Copy link
Contributor

Back to initial / exit full screen PR

@zhouyx
Copy link
Contributor Author

zhouyx commented Nov 13, 2018

Notes from today's meeting:

  1. Transition animation required from init prompt (30vh) to full screen
  2. Need an exit-fullscreen API to return from fullscreen back to the init prompt
  3. Transition animation required from full screen back to init prompt(30vh)
  4. No transition animation required to remove iframe. (optionally we can try fade out)
  5. @torch2424 to create an example page with the transitions and test in real devices.

@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @torch2424 Do you have any updates?

@torch2424
Copy link
Contributor

Need to change UI API:

{
type: 'consent-ui',
response: 'some-event'
}

@torch2424
Copy link
Contributor

Finished as of #19841

Continuing in #19969

Opened an issue for the optional item at: #19970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants