Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP-CONSENT v2 UI Followup Design Changes #19969

Closed
5 tasks done
torch2424 opened this issue Dec 19, 2018 · 1 comment · Fixed by #20100
Closed
5 tasks done

AMP-CONSENT v2 UI Followup Design Changes #19969

torch2424 opened this issue Dec 19, 2018 · 1 comment · Fixed by #20100

Comments

@torch2424
Copy link
Contributor

torch2424 commented Dec 19, 2018

relates to #18828
relates to #19841

cc @zhouyx

After (UI/UX) design review with @spacedino , we came to the following remaning UI / UX things we should address before completing the AMP Consent v2 UI/UX:

  • Implement Nicer Example in diy-consent.html
  • Fix the Flash of the "teal" background in diy-consent.html
  • Compensate for the iOS Safari Nav Bar.
    • If easy fix, have the consent bound to the bottom of the nav bar, and raise and lower with the nav bar.
    • If not easy, make the height calc(30vh + /*iOS Bottom Nav Bar Height*/), and document for CMPs
    • Update diy-consent.html to show this behavior
  • Add drop shadow to the loading placeholder bottom footer thing (same shadow from sticky ad)
  • Add 8px Rounded corners
@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @torch2424 Please add an appropriate category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants