Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove amp-action-macro experiment. #19495

Closed
alabiaga opened this issue Nov 28, 2018 · 1 comment
Closed

Remove amp-action-macro experiment. #19495

alabiaga opened this issue Nov 28, 2018 · 1 comment
Assignees
@dreamofabear
Labels
Cleanup AMP Experiments
Milestone
Pending Triage

Comments

@alabiaga
Copy link
Contributor

#19494
@alabiaga alabiaga self-assigned this Nov 28, 2018
@ampprojectbot ampprojectbot added this to the Pending Triage milestone Dec 5, 2018
@alabiaga
Copy link
Contributor Author

alabiaga commented Oct 1, 2019

Cleanup PR: #24810

@alabiaga alabiaga closed this as completed Oct 1, 2019
@alanorozco alanorozco mentioned this issue Jan 8, 2021
Merged
alanorozco added a commit to alanorozco/amphtml that referenced this issue Jan 8, 2021
@alanorozco
🚮 Sweep experiments older than 2021-01-07
2f54f52 
Sweep experiments last flipped globally up to 2021-01-07:

- (2019-10-01, 0ab715e) `amp-action-macro`: 1

---

### Cleanup issues

Close these once they've been addressed and this PR has been merged:

- [ ] `amp-action-macro`: ampproject#19495

---

### ⚠️ Javascript source files require intervention

The following may contain errors and/or require intervention to remove superfluous conditionals:

- [ ] `extensions/amp-action-macro/0.1/amp-action-macro.js`
- [ ] `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js`

Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup)

---

### ⚠️ HTML files may still contain references

The following HTML files contain references to experiment names which may be stale and should be manually removed:

- [ ] `examples/amp-action-macro.html`

Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)
@alanorozco alanorozco reopened this Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamofabear dreamofabear

Labels
Cleanup AMP Experiments
Projects
None yet
Milestone
Pending Triage
Development

No branches or pull requests
4 participants
@alanorozco @alabiaga @dreamofabear @ampprojectbot